Fix two issues with the panel-lg-sw43408 driver reported by the kernel
test robot.
Signed-off-by: Dmitry Baryshkov <[email protected]>
---
Dmitry Baryshkov (2):
drm/panel/lg-sw43408: depends on CONFIG_DRM_DISPLAY_DP_HELPER
drm/panel/lg-sw43408: mark sw43408_backlight_ops as static
drivers/gpu/drm/panel/Kconfig | 1 +
drivers/gpu/drm/panel/panel-lg-sw43408.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
---
base-commit: a35e92ef04c07bd473404b9b73d489aea19a60a8
change-id: 20240420-panel-sw43408-fix-ff6549c121be
Best regards,
--
Dmitry Baryshkov <[email protected]>
This panel driver uses DSC PPS functions and as such depends on the
DRM_DISPLAY_DP_HELPER. Add missing dependency
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Dmitry Baryshkov <[email protected]>
---
drivers/gpu/drm/panel/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index ab67789e59a2..5e6692207beb 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -340,6 +340,7 @@ config DRM_PANEL_LG_SW43408
depends on OF
depends on DRM_MIPI_DSI
depends on BACKLIGHT_CLASS_DEVICE
+ depends on DRM_DISPLAY_DP_HELPER
help
Say Y here if you want to enable support for LG sw43408 panel.
The panel has a 1080x2160@60Hz resolution and uses 24 bit RGB per
--
2.39.2
Fix sparse warning regarding symbol 'sw43408_backlight_ops' not being
declared.
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Dmitry Baryshkov <[email protected]>
---
drivers/gpu/drm/panel/panel-lg-sw43408.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-lg-sw43408.c b/drivers/gpu/drm/panel/panel-lg-sw43408.c
index 115f4702d59f..2b3a73696dce 100644
--- a/drivers/gpu/drm/panel/panel-lg-sw43408.c
+++ b/drivers/gpu/drm/panel/panel-lg-sw43408.c
@@ -182,7 +182,7 @@ static int sw43408_backlight_update_status(struct backlight_device *bl)
return mipi_dsi_dcs_set_display_brightness_large(dsi, brightness);
}
-const struct backlight_ops sw43408_backlight_ops = {
+static const struct backlight_ops sw43408_backlight_ops = {
.update_status = sw43408_backlight_update_status,
};
--
2.39.2
On 20/04/2024 04:41, Dmitry Baryshkov wrote:
> Fix sparse warning regarding symbol 'sw43408_backlight_ops' not being
> declared.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Dmitry Baryshkov <[email protected]>
No fixed either ?
> ---
> drivers/gpu/drm/panel/panel-lg-sw43408.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-lg-sw43408.c b/drivers/gpu/drm/panel/panel-lg-sw43408.c
> index 115f4702d59f..2b3a73696dce 100644
> --- a/drivers/gpu/drm/panel/panel-lg-sw43408.c
> +++ b/drivers/gpu/drm/panel/panel-lg-sw43408.c
> @@ -182,7 +182,7 @@ static int sw43408_backlight_update_status(struct backlight_device *bl)
> return mipi_dsi_dcs_set_display_brightness_large(dsi, brightness);
> }
>
> -const struct backlight_ops sw43408_backlight_ops = {
> +static const struct backlight_ops sw43408_backlight_ops = {
> .update_status = sw43408_backlight_update_status,
> };
>
>
Reviewed-by: Neil Armstrong <[email protected]>
On 20/04/2024 04:41, Dmitry Baryshkov wrote:
> This panel driver uses DSC PPS functions and as such depends on the
> DRM_DISPLAY_DP_HELPER. Add missing dependency
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
No Fixes ?
> Signed-off-by: Dmitry Baryshkov <[email protected]>
> ---
> drivers/gpu/drm/panel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index ab67789e59a2..5e6692207beb 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -340,6 +340,7 @@ config DRM_PANEL_LG_SW43408
> depends on OF
> depends on DRM_MIPI_DSI
> depends on BACKLIGHT_CLASS_DEVICE
> + depends on DRM_DISPLAY_DP_HELPER
> help
> Say Y here if you want to enable support for LG sw43408 panel.
> The panel has a 1080x2160@60Hz resolution and uses 24 bit RGB per
>
Reviewed-by: Neil Armstrong <[email protected]>
On Wed, 24 Apr 2024 at 09:54, Neil Armstrong <[email protected]> wrote:
>
> On 20/04/2024 04:41, Dmitry Baryshkov wrote:
> > This panel driver uses DSC PPS functions and as such depends on the
> > DRM_DISPLAY_DP_HELPER. Add missing dependency
> >
> > Reported-by: kernel test robot <[email protected]>
> > Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
>
> No Fixes ?
I'll add Fixes for v2. I'm waiting for the discussion on Kconfig to settle.
>
> > Signed-off-by: Dmitry Baryshkov <[email protected]>
> > ---
> > drivers/gpu/drm/panel/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> > index ab67789e59a2..5e6692207beb 100644
> > --- a/drivers/gpu/drm/panel/Kconfig
> > +++ b/drivers/gpu/drm/panel/Kconfig
> > @@ -340,6 +340,7 @@ config DRM_PANEL_LG_SW43408
> > depends on OF
> > depends on DRM_MIPI_DSI
> > depends on BACKLIGHT_CLASS_DEVICE
> > + depends on DRM_DISPLAY_DP_HELPER
> > help
> > Say Y here if you want to enable support for LG sw43408 panel.
> > The panel has a 1080x2160@60Hz resolution and uses 24 bit RGB per
> >
>
> Reviewed-by: Neil Armstrong <[email protected]>
--
With best wishes
Dmitry
Hi,
On Wed, Apr 24, 2024 at 10:43:32AM +0300, Dmitry Baryshkov wrote:
> On Wed, 24 Apr 2024 at 09:54, Neil Armstrong <[email protected]> wrote:
> >
> > On 20/04/2024 04:41, Dmitry Baryshkov wrote:
> > > This panel driver uses DSC PPS functions and as such depends on the
> > > DRM_DISPLAY_DP_HELPER. Add missing dependency
> > >
> > > Reported-by: kernel test robot <[email protected]>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> >
> > No Fixes ?
>
> I'll add Fixes for v2. I'm waiting for the discussion on Kconfig to settle.
>
> >
> > > Signed-off-by: Dmitry Baryshkov <[email protected]>
> > > ---
> > > drivers/gpu/drm/panel/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> > > index ab67789e59a2..5e6692207beb 100644
> > > --- a/drivers/gpu/drm/panel/Kconfig
> > > +++ b/drivers/gpu/drm/panel/Kconfig
> > > @@ -340,6 +340,7 @@ config DRM_PANEL_LG_SW43408
> > > depends on OF
> > > depends on DRM_MIPI_DSI
> > > depends on BACKLIGHT_CLASS_DEVICE
> > > + depends on DRM_DISPLAY_DP_HELPER
> > > help
> > > Say Y here if you want to enable support for LG sw43408 panel.
> > > The panel has a 1080x2160@60Hz resolution and uses 24 bit RGB per
> > >
> >
> > Reviewed-by: Neil Armstrong <[email protected]>
There's an ongoing discussion about reverting the whole Kconfig rework
thing here and the dust hasn't settled yet:
https://lore.kernel.org/r/[email protected]
I don't think there's anything you need to do now, but it's probably
good to keep it in mind.
Maxime