2024-04-24 13:56:39

by Nikolaos Pasaloukos

Subject: [PATCH v2 2/7] dt-bindings: arm: blaize: Add Blaize BLZP1600 SoC

Add device tree bindings for the Blaize BLZP1600 CB2
development board (carrier board), which uses the
BLZP1600 SoM.

Reviewed-by: James Cowgill <[email protected]>
Reviewed-by: Matt Redfearn <[email protected]>
Reviewed-by: Neil Jones <[email protected]>
Signed-off-by: Nikolaos Pasaloukos <[email protected]>
---
.../devicetree/bindings/arm/blaize.yaml | 40 +++++++++++++++++++
1 file changed, 40 insertions(+)
create mode 100644 Documentation/devicetree/bindings/arm/blaize.yaml

diff --git a/Documentation/devicetree/bindings/arm/blaize.yaml b/Documentation/devicetree/bindings/arm/blaize.yaml
new file mode 100644
index 000000000000..8034aeb7a2b4
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/blaize.yaml
@@ -0,0 +1,40 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/blaize.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Blaize Platforms
+
+maintainers:
+ - James Cowgill <[email protected]>
+ - Matt Redfearn <[email protected]>
+ - Neil Jones <[email protected]>
+ - Nikolaos Pasaloukos <[email protected]>
+
+description: |
+ Blaize Platforms using SoCs designed by Blaize Inc.
+
+ The products currently based on the BLZP1600 SoC:
+
+ - BLZP1600-SoM: SoM module
+ - BLZP1600-CB2: Development board CB2 based on BLZP1600-SoM
+
+ The compatible property should follow the format:
+
+ compatible = "blaize,blzp1600-cb2", "blaize,blzp1600";
+
+properties:
+ $nodename:
+ const: '/'
+ compatible:
+ oneOf:
+ - description: Blaize BLZP1600 based boards
+ items:
+ - enum:
+ - blaize,blzp1600-cb2
+ - const: blaize,blzp1600
+
+additionalProperties: true
+
+...
--
2.34.1

2024-04-24 14:32:11

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 2/7] dt-bindings: arm: blaize: Add Blaize BLZP1600 SoC

On 24/04/2024 15:32, Niko Pasaloukos wrote:
> Add device tree bindings for the Blaize BLZP1600 CB2
> development board (carrier board), which uses the
> BLZP1600 SoM.
>
> Reviewed-by: James Cowgill <[email protected]>
> Reviewed-by: Matt Redfearn <[email protected]>
> Reviewed-by: Neil Jones <[email protected]>
> Signed-off-by: Nikolaos Pasaloukos <[email protected]>
> ---
> .../devicetree/bindings/arm/blaize.yaml | 40 +++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/blaize.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/blaize.yaml b/Documentation/devicetree/bindings/arm/blaize.yaml
> new file mode 100644
> index 000000000000..8034aeb7a2b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/blaize.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/blaize.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Blaize Platforms
> +
> +maintainers:
> + - James Cowgill <[email protected]>
> + - Matt Redfearn <[email protected]>
> + - Neil Jones <[email protected]>
> + - Nikolaos Pasaloukos <[email protected]>
> +
> +description: |
> + Blaize Platforms using SoCs designed by Blaize Inc.
> +
> + The products currently based on the BLZP1600 SoC:
> +
> + - BLZP1600-SoM: SoM module
> + - BLZP1600-CB2: Development board CB2 based on BLZP1600-SoM
> +
> + The compatible property should follow the format:
> +
> + compatible = "blaize,blzp1600-cb2", "blaize,blzp1600";

Drop last three lines. Redundant. Your three reviewing folks should tell
you that...

> +
> +properties:
> + $nodename:

Best regards,
Krzysztof