2024-04-24 16:27:56

by Kees Cook

Subject: [PATCH] ubsan: Remove 1-element array usage in debug reporting

The "type_name" character array was still marked as a 1-element array.
While we don't validate strings used in format arguments yet, let's fix
this before it causes trouble some future day.

Signed-off-by: Kees Cook <[email protected]>
---
Cc: Gustavo A. R. Silva <[email protected]>
Cc: Marco Elver <[email protected]>
Cc: Andrey Konovalov <[email protected]>
Cc: Andrey Ryabinin <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
lib/ubsan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ubsan.h b/lib/ubsan.h
index 0abbbac8700d..50ef50811b7c 100644
--- a/lib/ubsan.h
+++ b/lib/ubsan.h
@@ -43,7 +43,7 @@ enum {
struct type_descriptor {
u16 type_kind;
u16 type_info;
- char type_name[1];
+ char type_name[];
};

struct source_location {
--
2.34.1

2024-04-24 21:15:00

by Gustavo A. R. Silva

Subject: Re: [PATCH] ubsan: Remove 1-element array usage in debug reporting

On 24/04/24 10:27, Kees Cook wrote:
> The "type_name" character array was still marked as a 1-element array.
> While we don't validate strings used in format arguments yet, let's fix
> this before it causes trouble some future day.
>
> Signed-off-by: Kees Cook <[email protected]>

Reviewed-by: Gustavo A. R. Silva <[email protected]>

Thanks!
--
Gustavo

> ---
> Cc: Gustavo A. R. Silva <[email protected]>
> Cc: Marco Elver <[email protected]>
> Cc: Andrey Konovalov <[email protected]>
> Cc: Andrey Ryabinin <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> lib/ubsan.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/ubsan.h b/lib/ubsan.h
> index 0abbbac8700d..50ef50811b7c 100644
> --- a/lib/ubsan.h
> +++ b/lib/ubsan.h
> @@ -43,7 +43,7 @@ enum {
> struct type_descriptor {
> u16 type_kind;
> u16 type_info;
> - char type_name[1];
> + char type_name[];
> };
>
> struct source_location {