2024-04-24 15:48:32

by Robert Richter

Subject: [PATCH v3] cxl: Fix use of phys_to_target_node() for x86

The CXL driver uses both functions phys_to_target_node() and
memory_add_physaddr_to_nid(). The x86 architecture relies on the
NUMA_KEEP_MEMINFO kernel option enabled for both functions to work
correct. Update Kconfig to make sure the option is always enabled for
the driver.

Suggested-by: Dan Williams <[email protected]>
Link: http://lore.kernel.org/r/65f8b191c0422_aa222941b@dwillia2-mobl3.amr.corp.intel.com.notmuch
Reviewed-by: Ira Weiny <[email protected]>
Reviewed-by: Dan Williams <[email protected]>
Signed-off-by: Robert Richter <[email protected]>
---
V3: updated SOB chain
---
drivers/cxl/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
index 67998dbd1d46..6140b3529a29 100644
--- a/drivers/cxl/Kconfig
+++ b/drivers/cxl/Kconfig
@@ -6,6 +6,7 @@ menuconfig CXL_BUS
select FW_UPLOAD
select PCI_DOE
select FIRMWARE_TABLE
+ select NUMA_KEEP_MEMINFO if (NUMA && X86)
help
CXL is a bus that is electrically compatible with PCI Express, but
layers three protocols on that signalling (CXL.io, CXL.cache, and
--
2.39.2

2024-04-24 23:37:18

by Davidlohr Bueso

Subject: Re: [PATCH v3] cxl: Fix use of phys_to_target_node() for x86

On Wed, 24 Apr 2024, Robert Richter wrote:

>The CXL driver uses both functions phys_to_target_node() and
>memory_add_physaddr_to_nid(). The x86 architecture relies on the
>NUMA_KEEP_MEMINFO kernel option enabled for both functions to work
>correct. Update Kconfig to make sure the option is always enabled for
>the driver.
>
>Suggested-by: Dan Williams <[email protected]>
>Link: http://lore.kernel.org/r/65f8b191c0422_aa222941b@dwillia2-mobl3.amr.corp.intel.com.notmuch
>Reviewed-by: Ira Weiny <[email protected]>
>Reviewed-by: Dan Williams <[email protected]>
>Signed-off-by: Robert Richter <[email protected]>

Reviewed-by: Davidlohr Bueso <[email protected]>