2024-04-24 11:40:29

by Dan Carpenter

Subject: [PATCH] cpufreq: sun50i: fix error returns in dt_has_supported_hw()

The dt_has_supported_hw() function returns type bool. That means these
negative error codes are cast to true but the function should return
false instead.

Fixes: fa5aec9561cf ("cpufreq: sun50i: Add support for opp_supported_hw")
Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/cpufreq/sun50i-cpufreq-nvmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
index cd50cea16a87..0b882765cd66 100644
--- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c
+++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
@@ -136,11 +136,11 @@ static bool dt_has_supported_hw(void)

cpu_dev = get_cpu_device(0);
if (!cpu_dev)
- return -ENODEV;
+ return false;

np = dev_pm_opp_of_get_opp_desc_node(cpu_dev);
if (!np)
- return -ENOENT;
+ return false;

for_each_child_of_node(np, opp) {
if (of_find_property(opp, "opp-supported-hw", NULL)) {
--
2.43.0

2024-04-24 15:53:26

by Andre Przywara

Subject: Re: [PATCH] cpufreq: sun50i: fix error returns in dt_has_supported_hw()

On Wed, 24 Apr 2024 14:40:11 +0300
Dan Carpenter <[email protected]> wrote:

Hi Dan,

thanks for having a look!

> The dt_has_supported_hw() function returns type bool. That means these
> negative error codes are cast to true but the function should return
> false instead.

Ouch, of course! I refactored the function during development, but missed
that part.

> Fixes: fa5aec9561cf ("cpufreq: sun50i: Add support for opp_supported_hw")
> Signed-off-by: Dan Carpenter <[email protected]>

Reviewed-by: Andre Przywara <[email protected]>

Thanks,
Andre

> ---
> drivers/cpufreq/sun50i-cpufreq-nvmem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> index cd50cea16a87..0b882765cd66 100644
> --- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> @@ -136,11 +136,11 @@ static bool dt_has_supported_hw(void)
>
> cpu_dev = get_cpu_device(0);
> if (!cpu_dev)
> - return -ENODEV;
> + return false;
>
> np = dev_pm_opp_of_get_opp_desc_node(cpu_dev);
> if (!np)
> - return -ENOENT;
> + return false;
>
> for_each_child_of_node(np, opp) {
> if (of_find_property(opp, "opp-supported-hw", NULL)) {

2024-04-24 19:01:50

by Jernej Škrabec

Subject: Re: [PATCH] cpufreq: sun50i: fix error returns in dt_has_supported_hw()

Dne sreda, 24. april 2024 ob 13:40:11 GMT +2 je Dan Carpenter napisal(a):
> The dt_has_supported_hw() function returns type bool. That means these
> negative error codes are cast to true but the function should return
> false instead.
>
> Fixes: fa5aec9561cf ("cpufreq: sun50i: Add support for opp_supported_hw")
> Signed-off-by: Dan Carpenter <[email protected]>

Reviewed-by: Jernej Skrabec <[email protected]>

Best regards,
Jernej

> ---
> drivers/cpufreq/sun50i-cpufreq-nvmem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/sun50i-cpufreq-nvmem.c b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> index cd50cea16a87..0b882765cd66 100644
> --- a/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> +++ b/drivers/cpufreq/sun50i-cpufreq-nvmem.c
> @@ -136,11 +136,11 @@ static bool dt_has_supported_hw(void)
>
> cpu_dev = get_cpu_device(0);
> if (!cpu_dev)
> - return -ENODEV;
> + return false;
>
> np = dev_pm_opp_of_get_opp_desc_node(cpu_dev);
> if (!np)
> - return -ENOENT;
> + return false;
>
> for_each_child_of_node(np, opp) {
> if (of_find_property(opp, "opp-supported-hw", NULL)) {
>

2024-04-25 05:08:47

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: sun50i: fix error returns in dt_has_supported_hw()

On 24-04-24, 14:40, Dan Carpenter wrote:
> The dt_has_supported_hw() function returns type bool. That means these
> negative error codes are cast to true but the function should return
> false instead.
>
> Fixes: fa5aec9561cf ("cpufreq: sun50i: Add support for opp_supported_hw")
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
> drivers/cpufreq/sun50i-cpufreq-nvmem.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Applied. Thanks.

--
viresh