2024-04-25 15:07:49

by Yifan Zhao

Subject: [f2fs-dev] [PATCH] f2fs: remove redundant parameter in is_next_segment_free()

is_next_segment_free() takes a redundant `type` parameter. Remove it.

Signed-off-by: Yifan Zhao <[email protected]>
---
fs/f2fs/segment.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 2206199e8099..8d63ddfe4a77 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -2645,7 +2645,7 @@ static void write_current_sum_page(struct f2fs_sb_info *sbi,
}

static int is_next_segment_free(struct f2fs_sb_info *sbi,
- struct curseg_info *curseg, int type)
+ struct curseg_info *curseg)
{
unsigned int segno = curseg->segno + 1;
struct free_segmap_info *free_i = FREE_I(sbi);
@@ -3073,8 +3073,7 @@ static bool need_new_seg(struct f2fs_sb_info *sbi, int type)
if (!is_set_ckpt_flags(sbi, CP_CRC_RECOVERY_FLAG) &&
curseg->seg_type == CURSEG_WARM_NODE)
return true;
- if (curseg->alloc_type == LFS &&
- is_next_segment_free(sbi, curseg, type) &&
+ if (curseg->alloc_type == LFS && is_next_segment_free(sbi, curseg) &&
likely(!is_sbi_flag_set(sbi, SBI_CP_DISABLED)))
return true;
if (!f2fs_need_SSR(sbi) || !get_ssr_segment(sbi, type, SSR, 0))
--
2.44.0

2024-04-26 09:41:27

by Chao Yu

Subject: Re: [f2fs-dev] [PATCH] f2fs: remove redundant parameter in is_next_segment_free()

On 2024/4/25 22:55, Yifan Zhao wrote:
> is_next_segment_free() takes a redundant `type` parameter. Remove it.
>
> Signed-off-by: Yifan Zhao <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2024-05-11 00:54:03

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH] f2fs: remove redundant parameter in is_next_segment_free()

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Thu, 25 Apr 2024 22:55:28 +0800 you wrote:
> is_next_segment_free() takes a redundant `type` parameter. Remove it.
>
> Signed-off-by: Yifan Zhao <[email protected]>
> ---
> fs/f2fs/segment.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)

Here is the summary with links:
- [f2fs-dev] f2fs: remove redundant parameter in is_next_segment_free()
https://git.kernel.org/jaegeuk/f2fs/c/ecd69be71aad

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html