2024-04-26 17:35:31

by Mickaël Salaün

Subject: [PATCH v1 1/5] selftests/pidfd: Fix config for pidfd_setns_test

Required by switch_timens() to open /proc/self/ns/time_for_children.

CONFIG_GENERIC_VDSO_TIME_NS is not available on UML, so pidfd_setns_test
cannot be run successfully on this architecture.

Cc: Christian Brauner <[email protected]>
Cc: Shuah Khan <[email protected]>
Fixes: 2b40c5db73e2 ("selftests/pidfd: add pidfd setns tests")
Signed-off-by: Mickaël Salaün <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
tools/testing/selftests/pidfd/config | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/pidfd/config b/tools/testing/selftests/pidfd/config
index f6f2965e17af..6133524710f7 100644
--- a/tools/testing/selftests/pidfd/config
+++ b/tools/testing/selftests/pidfd/config
@@ -3,5 +3,7 @@ CONFIG_IPC_NS=y
CONFIG_USER_NS=y
CONFIG_PID_NS=y
CONFIG_NET_NS=y
+CONFIG_TIME_NS=y
+CONFIG_GENERIC_VDSO_TIME_NS=y
CONFIG_CGROUPS=y
CONFIG_CHECKPOINT_RESTORE=y
--
2.44.0

2024-04-26 19:37:23

by Kees Cook

Subject: Re: [PATCH v1 1/5] selftests/pidfd: Fix config for pidfd_setns_test

On Fri, Apr 26, 2024 at 07:22:48PM +0200, Micka?l Sala?n wrote:
> Required by switch_timens() to open /proc/self/ns/time_for_children.
>
> CONFIG_GENERIC_VDSO_TIME_NS is not available on UML, so pidfd_setns_test
> cannot be run successfully on this architecture.
>
> Cc: Christian Brauner <[email protected]>
> Cc: Shuah Khan <[email protected]>
> Fixes: 2b40c5db73e2 ("selftests/pidfd: add pidfd setns tests")
> Signed-off-by: Micka?l Sala?n <[email protected]>

Ah, UML continues to be a bit weird. :)

Reviewed-by: Kees Cook <[email protected]>

--
Kees Cook