2024-04-26 20:23:11

by Rob Herring

[permalink] [raw]
Subject: [PATCH] dt-bindings: Drop unnecessary quotes on keys

The yamllint quoted-strings check wasn't checking keys for quotes, but
support for checking keys was added in 1.34 release. Fix all the errors
found when enabling the check.

Clean-up the xilinx-versal-cpm formatting while we're here.

Signed-off-by: Rob Herring (Arm) <[email protected]>
---
Documentation/devicetree/bindings/net/sff,sfp.yaml | 12 ++++++------
.../devicetree/bindings/pci/xilinx-versal-cpm.yaml | 7 +++++--
.../devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 2 +-
.../devicetree/bindings/phy/brcm,sata-phy.yaml | 8 ++++----
.../devicetree/bindings/regulator/ti,tps62864.yaml | 2 +-
.../bindings/soc/tegra/nvidia,tegra20-pmc.yaml | 6 +++---
Documentation/devicetree/bindings/tpm/ibm,vtpm.yaml | 4 ++--
7 files changed, 22 insertions(+), 19 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/sff,sfp.yaml b/Documentation/devicetree/bindings/net/sff,sfp.yaml
index bf6cbc7c2ba3..90611b598d2b 100644
--- a/Documentation/devicetree/bindings/net/sff,sfp.yaml
+++ b/Documentation/devicetree/bindings/net/sff,sfp.yaml
@@ -29,39 +29,39 @@ properties:
allowable by a module in the slot, in milli-Watts. Presently, modules can
be up to 1W, 1.5W or 2W.

- "mod-def0-gpios":
+ mod-def0-gpios:
maxItems: 1
description:
GPIO phandle and a specifier of the MOD-DEF0 (AKA Mod_ABS) module
presence input gpio signal, active (module absent) high. Must not be
present for SFF modules

- "los-gpios":
+ los-gpios:
maxItems: 1
description:
GPIO phandle and a specifier of the Receiver Loss of Signal Indication
input gpio signal, active (signal lost) high

- "tx-fault-gpios":
+ tx-fault-gpios:
maxItems: 1
description:
GPIO phandle and a specifier of the Module Transmitter Fault input gpio
signal, active (fault condition) high

- "tx-disable-gpios":
+ tx-disable-gpios:
maxItems: 1
description:
GPIO phandle and a specifier of the Transmitter Disable output gpio
signal, active (Tx disable) high

- "rate-select0-gpios":
+ rate-select0-gpios:
maxItems: 1
description:
GPIO phandle and a specifier of the Rx Signaling Rate Select (AKA RS0)
output gpio signal, low - low Rx rate, high - high Rx rate Must not be
present for SFF modules

- "rate-select1-gpios":
+ rate-select1-gpios:
maxItems: 1
description:
GPIO phandle and a specifier of the Tx Signaling Rate Select (AKA RS1)
diff --git a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
index 4734be456bde..c41344f8a242 100644
--- a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
+++ b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
@@ -48,13 +48,16 @@ properties:
interrupt-controller:
description: Interrupt controller node for handling legacy PCI interrupts.
type: object
+ additionalProperties: false
+
properties:
"#address-cells":
const: 0
+
"#interrupt-cells":
const: 1
- "interrupt-controller": true
- additionalProperties: false
+
+ interrupt-controller: true

required:
- reg
diff --git a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml
index 426f90a47f35..cbe832c23dae 100644
--- a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml
@@ -84,7 +84,7 @@ properties:
"#interrupt-cells":
const: 1

- "interrupt-controller": true
+ interrupt-controller: true

required:
- "#address-cells"
diff --git a/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml
index 8467c8e6368c..439bda142764 100644
--- a/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml
@@ -59,14 +59,14 @@ patternProperties:
"#phy-cells":
const: 0

- "brcm,enable-ssc":
+ brcm,enable-ssc:
$ref: /schemas/types.yaml#/definitions/flag
description: |
Use spread spectrum clocking (SSC) on this port
This property is not applicable for "brcm,iproc-ns2-sata-phy",
"brcm,iproc-nsp-sata-phy" and "brcm,iproc-sr-sata-phy".

- "brcm,rxaeq-mode":
+ brcm,rxaeq-mode:
$ref: /schemas/types.yaml#/definitions/string
description:
String that indicates the desired RX equalizer mode.
@@ -75,7 +75,7 @@ patternProperties:
- auto
- manual

- "brcm,rxaeq-value":
+ brcm,rxaeq-value:
$ref: /schemas/types.yaml#/definitions/uint32
description: |
When 'brcm,rxaeq-mode' is set to "manual", provides the RX
@@ -83,7 +83,7 @@ patternProperties:
minimum: 0
maximum: 63

- "brcm,tx-amplitude-millivolt":
+ brcm,tx-amplitude-millivolt:
description: |
Transmit amplitude voltage in millivolt.
$ref: /schemas/types.yaml#/definitions/uint32
diff --git a/Documentation/devicetree/bindings/regulator/ti,tps62864.yaml b/Documentation/devicetree/bindings/regulator/ti,tps62864.yaml
index 0f29c75f42ea..dddea27596e9 100644
--- a/Documentation/devicetree/bindings/regulator/ti,tps62864.yaml
+++ b/Documentation/devicetree/bindings/regulator/ti,tps62864.yaml
@@ -24,7 +24,7 @@ properties:
type: object

properties:
- "SW":
+ SW:
type: object
$ref: regulator.yaml#
unevaluatedProperties: false
diff --git a/Documentation/devicetree/bindings/soc/tegra/nvidia,tegra20-pmc.yaml b/Documentation/devicetree/bindings/soc/tegra/nvidia,tegra20-pmc.yaml
index b86f6f53ca95..7140c312d898 100644
--- a/Documentation/devicetree/bindings/soc/tegra/nvidia,tegra20-pmc.yaml
+++ b/Documentation/devicetree/bindings/soc/tegra/nvidia,tegra20-pmc.yaml
@@ -365,9 +365,9 @@ allOf:
additionalProperties: false

dependencies:
- "nvidia,suspend-mode": ["nvidia,core-pwr-off-time", "nvidia,cpu-pwr-off-time"]
- "nvidia,core-pwr-off-time": ["nvidia,core-pwr-good-time"]
- "nvidia,cpu-pwr-off-time": ["nvidia,cpu-pwr-good-time"]
+ nvidia,suspend-mode: ["nvidia,core-pwr-off-time", "nvidia,cpu-pwr-off-time"]
+ nvidia,core-pwr-off-time: ["nvidia,core-pwr-good-time"]
+ nvidia,cpu-pwr-off-time: ["nvidia,cpu-pwr-good-time"]

examples:
- |
diff --git a/Documentation/devicetree/bindings/tpm/ibm,vtpm.yaml b/Documentation/devicetree/bindings/tpm/ibm,vtpm.yaml
index 50a3fd31241c..8b0d3d4be5d8 100644
--- a/Documentation/devicetree/bindings/tpm/ibm,vtpm.yaml
+++ b/Documentation/devicetree/bindings/tpm/ibm,vtpm.yaml
@@ -33,13 +33,13 @@ properties:
reg:
maxItems: 1

- 'ibm,#dma-address-cells':
+ ibm,#dma-address-cells:
description:
number of cells that are used to encode the physical address field of
dma-window properties
$ref: /schemas/types.yaml#/definitions/uint32-array

- 'ibm,#dma-size-cells':
+ ibm,#dma-size-cells:
description:
number of cells that are used to encode the size field of
dma-window properties
--
2.43.0



2024-04-29 06:24:41

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: Drop unnecessary quotes on keys

On 26/04/2024 22:22, Rob Herring (Arm) wrote:
> The yamllint quoted-strings check wasn't checking keys for quotes, but
> support for checking keys was added in 1.34 release. Fix all the errors
> found when enabling the check.
>
> Clean-up the xilinx-versal-cpm formatting while we're here.
>
> Signed-off-by: Rob Herring (Arm) <[email protected]>
> ---

Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof


2024-04-29 14:46:00

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: Drop unnecessary quotes on keys

On Fri, Apr 26, 2024 at 03:22:37PM -0500, Rob Herring (Arm) wrote:
> The yamllint quoted-strings check wasn't checking keys for quotes, but
> support for checking keys was added in 1.34 release. Fix all the errors
> found when enabling the check.

Acked-by: Mark Brown <[email protected]>


Attachments:
(No filename) (296.00 B)
signature.asc (499.00 B)
Download all attachments

2024-04-29 15:12:39

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: Drop unnecessary quotes on keys

On Fri Apr 26, 2024 at 10:22 PM CEST, Rob Herring (Arm) wrote:
> The yamllint quoted-strings check wasn't checking keys for quotes, but
> support for checking keys was added in 1.34 release. Fix all the errors
> found when enabling the check.
>
> Clean-up the xilinx-versal-cpm formatting while we're here.
>
> Signed-off-by: Rob Herring (Arm) <[email protected]>
> ---
> Documentation/devicetree/bindings/net/sff,sfp.yaml | 12 ++++++------
> .../devicetree/bindings/pci/xilinx-versal-cpm.yaml | 7 +++++--
> .../devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 2 +-
> .../devicetree/bindings/phy/brcm,sata-phy.yaml | 8 ++++----
> .../devicetree/bindings/regulator/ti,tps62864.yaml | 2 +-
> .../bindings/soc/tegra/nvidia,tegra20-pmc.yaml | 6 +++---
> Documentation/devicetree/bindings/tpm/ibm,vtpm.yaml | 4 ++--
> 7 files changed, 22 insertions(+), 19 deletions(-)

Acked-by: Thierry Reding <[email protected]>


Attachments:
signature.asc (849.00 B)

2024-04-30 20:40:29

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: Drop unnecessary quotes on keys


On Fri, 26 Apr 2024 15:22:37 -0500, Rob Herring (Arm) wrote:
> The yamllint quoted-strings check wasn't checking keys for quotes, but
> support for checking keys was added in 1.34 release. Fix all the errors
> found when enabling the check.
>
> Clean-up the xilinx-versal-cpm formatting while we're here.
>
> Signed-off-by: Rob Herring (Arm) <[email protected]>
> ---
> Documentation/devicetree/bindings/net/sff,sfp.yaml | 12 ++++++------
> .../devicetree/bindings/pci/xilinx-versal-cpm.yaml | 7 +++++--
> .../devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 2 +-
> .../devicetree/bindings/phy/brcm,sata-phy.yaml | 8 ++++----
> .../devicetree/bindings/regulator/ti,tps62864.yaml | 2 +-
> .../bindings/soc/tegra/nvidia,tegra20-pmc.yaml | 6 +++---
> Documentation/devicetree/bindings/tpm/ibm,vtpm.yaml | 4 ++--
> 7 files changed, 22 insertions(+), 19 deletions(-)
>

Applied, thanks!