2024-04-26 21:52:16

by Rob Herring

[permalink] [raw]
Subject: [PATCH] regulator: dt-bindings: fixed-regulator: Add a preferred node name

Define "regulator-[0-9]v[0-9]" as the preferred node name for fixed
regulators. Other suffixes with names are also accepted. Combined,
these make up about half of the existing names in use.

For now this only serves as documentation as the schema still allows
anything to avoid lots of additional warnings for something low priority
to fix. Once a "no deprecated" mode is added to the tools, warnings can
be enabled selectively.

Signed-off-by: Rob Herring (Arm) <[email protected]>
---
.../devicetree/bindings/regulator/fixed-regulator.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
index 9ff9abf2691a..51e2f6fb7a5a 100644
--- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
@@ -41,6 +41,13 @@ allOf:
- gpios

properties:
+ $nodename:
+ anyOf:
+ - description: Preferred name is 'regulator-[0-9]v[0-9]'
+ pattern: '^regulator(-[0-9]+v[0-9]+|-[0-9a-z-]+)?$'
+ - description: Any name allowed
+ deprecated: true
+
compatible:
enum:
- regulator-fixed
--
2.43.0



2024-04-29 06:22:08

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] regulator: dt-bindings: fixed-regulator: Add a preferred node name

On 26/04/2024 23:51, Rob Herring (Arm) wrote:
> Define "regulator-[0-9]v[0-9]" as the preferred node name for fixed
> regulators. Other suffixes with names are also accepted. Combined,
> these make up about half of the existing names in use.
>
> For now this only serves as documentation as the schema still allows
> anything to avoid lots of additional warnings for something low priority
> to fix. Once a "no deprecated" mode is added to the tools, warnings can
> be enabled selectively.
>
> Signed-off-by: Rob Herring (Arm) <[email protected]>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2024-04-30 15:07:50

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: dt-bindings: fixed-regulator: Add a preferred node name

On Fri, 26 Apr 2024 16:51:46 -0500, Rob Herring (Arm) wrote:
> Define "regulator-[0-9]v[0-9]" as the preferred node name for fixed
> regulators. Other suffixes with names are also accepted. Combined,
> these make up about half of the existing names in use.
>
> For now this only serves as documentation as the schema still allows
> anything to avoid lots of additional warnings for something low priority
> to fix. Once a "no deprecated" mode is added to the tools, warnings can
> be enabled selectively.
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: dt-bindings: fixed-regulator: Add a preferred node name
commit: b6d4b3500d57370f5b3abf0701c9166b384db976

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark