With WERROR=y, which is default, clang is not happy:
../amd/pasid.c:168:3: error: call to undeclared function 'mmu_notifier_unregister'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
../amd/pasid.c:191:8: error: call to undeclared function 'mmu_notifier_register'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
2 errors generated.
Select missed dependency.
Fixes: a5a91e54846d ("iommu/amd: Add SVA domain support")
Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/iommu/amd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iommu/amd/Kconfig b/drivers/iommu/amd/Kconfig
index 68d8fc107cb9..994063e5586f 100644
--- a/drivers/iommu/amd/Kconfig
+++ b/drivers/iommu/amd/Kconfig
@@ -7,6 +7,7 @@ config AMD_IOMMU
select PCI_ATS
select PCI_PRI
select PCI_PASID
+ select MMU_NOTIFIER
select IOMMU_API
select IOMMU_IOVA
select IOMMU_IO_PGTABLE
--
2.43.0.rc1.1336.g36b5255a03ac
On Mon, Apr 29, 2024 at 02:17:07PM +0300, Andy Shevchenko wrote:
> With WERROR=y, which is default, clang is not happy:
>
> .../amd/pasid.c:168:3: error: call to undeclared function 'mmu_notifier_unregister'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> .../amd/pasid.c:191:8: error: call to undeclared function 'mmu_notifier_register'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 2 errors generated.
>
> Select missed dependency.
>
> Fixes: a5a91e54846d ("iommu/amd: Add SVA domain support")
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/iommu/amd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Jason Gunthorpe <[email protected]>
Jason
On Mon, Apr 29, 2024 at 02:17:07PM +0300, Andy Shevchenko wrote:
> drivers/iommu/amd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.