2024-04-29 17:13:25

by Sui Jingfeng

Subject: [PATCH] drm/panel: ili9341: Remove a superfluous else after return

The else clause after the ruturn clause is not useful.

Signed-off-by: Sui Jingfeng <[email protected]>
---
drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
index 3574681891e8..433572c4caf9 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
@@ -722,7 +722,8 @@ static int ili9341_probe(struct spi_device *spi)

if (!strcmp(id->name, "sf-tc240t-9370-t"))
return ili9341_dpi_probe(spi, dc, reset);
- else if (!strcmp(id->name, "yx240qv29"))
+
+ if (!strcmp(id->name, "yx240qv29"))
return ili9341_dbi_probe(spi, dc, reset);

return -1;
--
2.34.1

2024-04-29 23:11:15

by Jessica Zhang

Subject: Re: [PATCH] drm/panel: ili9341: Remove a superfluous else after return

On 4/29/2024 10:12 AM, Sui Jingfeng wrote:
> The else clause after the ruturn clause is not useful.

Hi Sui,

Spelling nit: ruturn --> return

Besides that,

Reviewed-by: Jessica Zhang <[email protected]>

Thanks,

Jessica Zhang

>
> Signed-off-by: Sui Jingfeng <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> index 3574681891e8..433572c4caf9 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
> @@ -722,7 +722,8 @@ static int ili9341_probe(struct spi_device *spi)
>
> if (!strcmp(id->name, "sf-tc240t-9370-t"))
> return ili9341_dpi_probe(spi, dc, reset);
> - else if (!strcmp(id->name, "yx240qv29"))
> +
> + if (!strcmp(id->name, "yx240qv29"))
> return ili9341_dbi_probe(spi, dc, reset);
>
> return -1;
> --
> 2.34.1
>

2024-04-30 17:10:50

by Sui Jingfeng

Subject: Re: [PATCH] drm/panel: ili9341: Remove a superfluous else after return

Hi,


On 2024/4/30 07:10, Jessica Zhang wrote:
>
>
> On 4/29/2024 10:12 AM, Sui Jingfeng wrote:
>> The else clause after the ruturn clause is not useful.
>
> Hi Sui,
>
> Spelling nit: ruturn --> return
>

Thanks for pointed out, will be fixed.


> Besides that,
>
> Reviewed-by: Jessica Zhang <[email protected]>
>
> Thanks,
>
> Jessica Zhang


Thanks, Jessica.