2024-04-30 12:19:34

by MD Danish Anwar

Subject: [PATCH] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

Add documentation for pa-stats node which is syscon regmap for
PA_STATS register. This will be used to dump statistics maintained by
ICSSG firmware.

Signed-off-by: MD Danish Anwar <[email protected]>
---
.../devicetree/bindings/soc/ti/ti,pruss.yaml | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
index c402cb2928e8..cb6f41660847 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
@@ -278,6 +278,23 @@ patternProperties:

additionalProperties: false

+ pa-stats@[a-f0-9]+$:
+ description: |
+ PA-STATS sub-module represented as a SysCon.
+
+ type: object
+
+ properties:
+ compatible:
+ items:
+ - const: ti,pruss-pa-st
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+ additionalProperties: false
+
interrupt-controller@[a-f0-9]+$:
description: |
PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
--
2.34.1

2024-05-01 10:29:13

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support

On 30/04/2024 14:19, MD Danish Anwar wrote:
> Add documentation for pa-stats node which is syscon regmap for
> PA_STATS register. This will be used to dump statistics maintained by
> ICSSG firmware.
>
> Signed-off-by: MD Danish Anwar <[email protected]>
> ---
> .../devicetree/bindings/soc/ti/ti,pruss.yaml | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> index c402cb2928e8..cb6f41660847 100644
> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> @@ -278,6 +278,23 @@ patternProperties:
>
> additionalProperties: false
>
> + pa-stats@[a-f0-9]+$:

Missing ^

> + description: |
> + PA-STATS sub-module represented as a SysCon.
> +
> + type: object
> +
> + properties:
> + compatible:
> + items:
> + - const: ti,pruss-pa-st
> + - const: syscon
> +

No resources? So you use it just to instantiate Linux driver? That's not
the purpose of DT. Just squash it into parent node?

> + reg:
> + maxItems: 1
> +
> + additionalProperties: false

Put it after type:object.

> +
> interrupt-controller@[a-f0-9]+$:
> description: |
> PRUSS INTC Node. Each PRUSS has a single interrupt controller instance

Best regards,
Krzysztof