2024-05-01 05:24:32

by Sui Jingfeng

Subject: [PATCH v2] drm/panel: ili9341: Remove a superfluous else after return

Because the else clause after the return clause is not useful, remove it
to get a better look.

Reviewed-by: Jessica Zhang <[email protected]>
Signed-off-by: Sui Jingfeng <[email protected]>
---
drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
index 3574681891e8..433572c4caf9 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c
@@ -722,7 +722,8 @@ static int ili9341_probe(struct spi_device *spi)

if (!strcmp(id->name, "sf-tc240t-9370-t"))
return ili9341_dpi_probe(spi, dc, reset);
- else if (!strcmp(id->name, "yx240qv29"))
+
+ if (!strcmp(id->name, "yx240qv29"))
return ili9341_dbi_probe(spi, dc, reset);

return -1;
--
2.34.1

2024-05-02 07:50:23

by Neil Armstrong

Subject: Re: [PATCH v2] drm/panel: ili9341: Remove a superfluous else after return

Hi,

On Wed, 01 May 2024 13:24:02 +0800, Sui Jingfeng wrote:
> Because the else clause after the return clause is not useful, remove it
> to get a better look.
>
>

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/1] drm/panel: ili9341: Remove a superfluous else after return
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/e91a36b472862a1d199ea8d1b1ca192a347bf33e

--
Neil