2024-04-30 21:50:58

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: Fixes tag needs some work in the bluetooth tree

---

Hi all,

In commit

91708e8a4376 ("Bluetooth: msft: fix slab-use-after-free in msft_do_close()")

Fixes tag

Fixes: 9e14606d8f38 ("Bluetooth: disable advertisement filters during suspend")

has these problem(s):

- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

Maybe you meant

Fixes: bf6a4e30ffbd ("Bluetooth: disable advertisement filters during suspend")

or

Fixes: 9e14606d8f38 ("Bluetooth: msft: Extended monitor tracking by address filter")

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2024-04-30 22:25:03

by Sungwoo Kim

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the bluetooth tree

---

Hi, sorry for the wrong fixed tag.

On Tue, Apr 30, 2024 at 5:50 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> In commit
>
> 91708e8a4376 ("Bluetooth: msft: fix slab-use-after-free in msft_do_close()")
>
> Fixes tag
>
> Fixes: 9e14606d8f38 ("Bluetooth: disable advertisement filters during suspend")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> Maybe you meant
>
> Fixes: bf6a4e30ffbd ("Bluetooth: disable advertisement filters during suspend")
>
> or
>
> Fixes: 9e14606d8f38 ("Bluetooth: msft: Extended monitor tracking by address filter")

The correct tag is:

Fixes: 5031ffcc79b8 ("Bluetooth: Keep MSFT ext info throughout a
hci_dev's life cycle")

Would you like me to send a new patch to fix this?

Thanks,
Sungwoo.