2024-05-01 01:19:37

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build failure after merge of the bluetooth tree

---

Hi all,

After merging the bluetooth tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

net/bluetooth/hci_core.c: In function 'hci_release_dev':
net/bluetooth/hci_core.c:2831:9: error: implicit declaration of function 'msft_release'; did you mean 'dst_release'? [-Werror=implicit-function-declaration]
2831 | msft_release(hdev);
| ^~~~~~~~~~~~
| dst_release
cc1: some warnings being treated as errors

Caused by commit

d85d07aefca7 ("Bluetooth: msft: fix slab-use-after-free in msft_do_close()")

(though I don't see why)

I have used the bluetooth tree from next-20240430 for today.

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2024-05-01 01:35:15

by Sungwoo Kim

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the bluetooth tree

---

Hi Stephen, thank you for reporting this.

On Tue, Apr 30, 2024 at 9:19 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the bluetooth tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> net/bluetooth/hci_core.c: In function 'hci_release_dev':
> net/bluetooth/hci_core.c:2831:9: error: implicit declaration of function 'msft_release'; did you mean 'dst_release'? [-Werror=implicit-function-declaration]

The patch was insufficient. If CONFIG_BT_MSFTEXT=n, msft.h does not
declare msft_release().
I will send a patch for this.

Thanks & Regards,
Sungwoo.