2024-05-01 11:22:23

by Colin Ian King

Subject: [PATCH][next] selftests/bpf: Fix spelling mistake "{GET|SET}SOCKOP" -> "{GET|SET}SOCKOPT"

There are two spelling mistakes in .descr literal strings. Fix them.

Signed-off-by: Colin Ian King <[email protected]>
---
tools/testing/selftests/bpf/prog_tests/sockopt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/bpf/prog_tests/sockopt.c b/tools/testing/selftests/bpf/prog_tests/sockopt.c
index eaac83a7f388..ecf5a7a047a4 100644
--- a/tools/testing/selftests/bpf/prog_tests/sockopt.c
+++ b/tools/testing/selftests/bpf/prog_tests/sockopt.c
@@ -933,7 +933,7 @@ static struct sockopt_test {
/* ==================== prog_type ==================== */

{
- .descr = "can attach only BPF_CGROUP_SETSOCKOP",
+ .descr = "can attach only BPF_CGROUP_SETSOCKOPT",
.insns = {
/* return 1 */
BPF_MOV64_IMM(BPF_REG_0, 1),
@@ -947,7 +947,7 @@ static struct sockopt_test {
},

{
- .descr = "can attach only BPF_CGROUP_GETSOCKOP",
+ .descr = "can attach only BPF_CGROUP_GETSOCKOPT",
.insns = {
/* return 1 */
BPF_MOV64_IMM(BPF_REG_0, 1),
--
2.39.2

2024-05-07 20:29:05

by Andrii Nakryiko

Subject: Re: [PATCH][next] selftests/bpf: Fix spelling mistake "{GET|SET}SOCKOP" -> "{GET|SET}SOCKOPT"

On Wed, May 1, 2024 at 4:21 AM Colin Ian King <[email protected]> wrote:
>
> There are two spelling mistakes in .descr literal strings. Fix them.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> tools/testing/selftests/bpf/prog_tests/sockopt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

This doesn't apply cleanly onto bpf-next/master, unfortunately. Can
you please rebase and resend?

pw-bot: cr


> diff --git a/tools/testing/selftests/bpf/prog_tests/sockopt.c b/tools/testing/selftests/bpf/prog_tests/sockopt.c
> index eaac83a7f388..ecf5a7a047a4 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sockopt.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sockopt.c
> @@ -933,7 +933,7 @@ static struct sockopt_test {
> /* ==================== prog_type ==================== */
>
> {
> - .descr = "can attach only BPF_CGROUP_SETSOCKOP",
> + .descr = "can attach only BPF_CGROUP_SETSOCKOPT",
> .insns = {
> /* return 1 */
> BPF_MOV64_IMM(BPF_REG_0, 1),
> @@ -947,7 +947,7 @@ static struct sockopt_test {
> },
>
> {
> - .descr = "can attach only BPF_CGROUP_GETSOCKOP",
> + .descr = "can attach only BPF_CGROUP_GETSOCKOPT",
> .insns = {
> /* return 1 */
> BPF_MOV64_IMM(BPF_REG_0, 1),
> --
> 2.39.2
>