2024-05-02 15:51:08

by Andy Shevchenko

[permalink] [raw]
Subject: [PATCH net-next v1 1/1] can: sja1000: plx_pci: Reuse predefined CTI subvendor ID

There is predefined PCI_SUBVENDOR_ID_CONNECT_TECH, use it in the driver.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/net/can/sja1000/plx_pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/can/sja1000/plx_pci.c b/drivers/net/can/sja1000/plx_pci.c
index 5de1ebb0c6f0..67e5316c6372 100644
--- a/drivers/net/can/sja1000/plx_pci.c
+++ b/drivers/net/can/sja1000/plx_pci.c
@@ -122,7 +122,6 @@ struct plx_pci_card {
#define TEWS_PCI_VENDOR_ID 0x1498
#define TEWS_PCI_DEVICE_ID_TMPC810 0x032A

-#define CTI_PCI_VENDOR_ID 0x12c4
#define CTI_PCI_DEVICE_ID_CRG001 0x0900

#define MOXA_PCI_VENDOR_ID 0x1393
@@ -358,7 +357,7 @@ static const struct pci_device_id plx_pci_tbl[] = {
{
/* Connect Tech Inc. CANpro/104-Plus Opto (CRG001) card */
PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
- CTI_PCI_VENDOR_ID, CTI_PCI_DEVICE_ID_CRG001,
+ PCI_SUBVENDOR_ID_CONNECT_TECH, CTI_PCI_DEVICE_ID_CRG001,
0, 0,
(kernel_ulong_t)&plx_pci_card_info_cti
},
--
2.43.0.rc1.1336.g36b5255a03ac



2024-05-04 09:14:29

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH net-next v1 1/1] can: sja1000: plx_pci: Reuse predefined CTI subvendor ID

On Thu, May 02, 2024 at 03:38:52PM +0300, Andy Shevchenko wrote:
> There is predefined PCI_SUBVENDOR_ID_CONNECT_TECH, use it in the driver.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Simon Horman <[email protected]>


2024-05-05 11:01:40

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH net-next v1 1/1] can: sja1000: plx_pci: Reuse predefined CTI subvendor ID

On 02.05.2024 15:38:52, Andy Shevchenko wrote:
> There is predefined PCI_SUBVENDOR_ID_CONNECT_TECH, use it in the driver.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Applied to linx-can-next

Thanks,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |


Attachments:
(No filename) (511.00 B)
signature.asc (499.00 B)
Download all attachments