2024-05-03 00:24:07

by Dr. David Alan Gilbert

[permalink] [raw]
Subject: [PATCH] power: Remove arch specific module bug stuff

From: "Dr. David Alan Gilbert" <[email protected]>

The last function to reference module_bug_list went in 2008's
commit b9754568ef17 ("powerpc: Remove dead module_find_bug code")
but I don't think that was called since 2006's
commit 73c9ceab40b1 ("[POWERPC] Generic BUG for powerpc")

Now that the list has gone, I think we can also clean up the bug
entries in mod_arch_specific.

Lightly boot tested.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
arch/powerpc/include/asm/module.h | 5 -----
arch/powerpc/kernel/module.c | 2 --
2 files changed, 7 deletions(-)

diff --git a/arch/powerpc/include/asm/module.h b/arch/powerpc/include/asm/module.h
index a8e2e8339fb7f..300c777cc3075 100644
--- a/arch/powerpc/include/asm/module.h
+++ b/arch/powerpc/include/asm/module.h
@@ -48,11 +48,6 @@ struct mod_arch_specific {
unsigned long tramp;
unsigned long tramp_regs;
#endif
-
- /* List of BUG addresses, source line numbers and filenames */
- struct list_head bug_list;
- struct bug_entry *bug_table;
- unsigned int num_bugs;
};

/*
diff --git a/arch/powerpc/kernel/module.c b/arch/powerpc/kernel/module.c
index f6d6ae0a16923..8989e069e3aae 100644
--- a/arch/powerpc/kernel/module.c
+++ b/arch/powerpc/kernel/module.c
@@ -17,8 +17,6 @@
#include <asm/setup.h>
#include <asm/sections.h>

-static LIST_HEAD(module_bug_list);
-
static const Elf_Shdr *find_section(const Elf_Ehdr *hdr,
const Elf_Shdr *sechdrs,
const char *name)
--
2.44.0



2024-05-08 13:48:21

by Michael Ellerman

[permalink] [raw]
Subject: Re: [PATCH] power: Remove arch specific module bug stuff

On Fri, 03 May 2024 01:23:17 +0100, [email protected] wrote:
> The last function to reference module_bug_list went in 2008's
> commit b9754568ef17 ("powerpc: Remove dead module_find_bug code")
> but I don't think that was called since 2006's
> commit 73c9ceab40b1 ("[POWERPC] Generic BUG for powerpc")
>
> Now that the list has gone, I think we can also clean up the bug
> entries in mod_arch_specific.
>
> [...]

Applied to powerpc/next.

[1/1] power: Remove arch specific module bug stuff
https://git.kernel.org/powerpc/c/4071739249fd2e647e7058dbab0db4ddc0a0c427

cheers