It is primarily based on the G12A thermal controller, with only a slight
variation in the offset value of the efuse parameters. Therefore, this
patch series provides appropriate platform data and dt-bindings to
ensure proper support.
Changes v2 since v1 at [1]:
- provide Neil RvB
- remove 'amlogic,a1-thermal' fallback, cause it's not needed
Links:
[1] https://lore.kernel.org/all/[email protected]/
Dmitry Rokosov (2):
dt-bindings: thermal: amlogic: add support for A1 thermal sensor
thermal: amlogic: support A1 SoC family Thermal Sensor controller
.../devicetree/bindings/thermal/amlogic,thermal.yaml | 12 +++++++-----
drivers/thermal/amlogic_thermal.c | 10 ++++++++++
2 files changed, 17 insertions(+), 5 deletions(-)
--
2.43.0
In comparison to other Amlogic chips, there is one key difference.
The offset for the sec_ao base, also known as u_efuse_off, is special,
while other aspects remain the same.
Signed-off-by: Dmitry Rokosov <[email protected]>
Reviewed-by: Neil Armstrong <[email protected]>
---
drivers/thermal/amlogic_thermal.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
index 5877cde25b79..1d23afd32013 100644
--- a/drivers/thermal/amlogic_thermal.c
+++ b/drivers/thermal/amlogic_thermal.c
@@ -222,6 +222,12 @@ static const struct amlogic_thermal_data amlogic_thermal_g12a_ddr_param = {
.regmap_config = &amlogic_thermal_regmap_config_g12a,
};
+static const struct amlogic_thermal_data amlogic_thermal_a1_cpu_param = {
+ .u_efuse_off = 0x114,
+ .calibration_parameters = &amlogic_thermal_g12a,
+ .regmap_config = &amlogic_thermal_regmap_config_g12a,
+};
+
static const struct of_device_id of_amlogic_thermal_match[] = {
{
.compatible = "amlogic,g12a-ddr-thermal",
@@ -231,6 +237,10 @@ static const struct of_device_id of_amlogic_thermal_match[] = {
.compatible = "amlogic,g12a-cpu-thermal",
.data = &amlogic_thermal_g12a_cpu_param,
},
+ {
+ .compatible = "amlogic,a1-cpu-thermal",
+ .data = &amlogic_thermal_a1_cpu_param,
+ },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, of_amlogic_thermal_match);
--
2.43.0
On 28/03/2024 20:13, Dmitry Rokosov wrote:
> It is primarily based on the G12A thermal controller, with only a slight
> variation in the offset value of the efuse parameters. Therefore, this
> patch series provides appropriate platform data and dt-bindings to
> ensure proper support.
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Hello Daniel,
Could you please let me know in which repository you have applied this
change? I am trying to cherry-pick the original applied commit and apply
it to our internal mainline branch instead of the internal commit.
However, I am unable to find the applied series in any of the
repositories on git.kernel.org.
On Thu, Apr 04, 2024 at 02:23:21PM +0200, Daniel Lezcano wrote:
> On 28/03/2024 20:13, Dmitry Rokosov wrote:
> > It is primarily based on the G12A thermal controller, with only a slight
> > variation in the offset value of the efuse parameters. Therefore, this
> > patch series provides appropriate platform data and dt-bindings to
> > ensure proper support.
>
>
> Applied, thanks
--
Thank you,
Dmitry
Hello Neil,
I hope you're doing well. I was wondering if you could assist me with
below problem.
I'm a bit confused about which kernel repository the series was applied
to. I asked Daniel about it, but unfortunately, I didn't receive any
feedback from him. Could you provide some clarification on this matter?
Thank you in advance for your help.
On Wed, Apr 17, 2024 at 11:40:07AM +0300, Dmitry Rokosov wrote:
> Hello Daniel,
>
> Could you please let me know in which repository you have applied this
> change? I am trying to cherry-pick the original applied commit and apply
> it to our internal mainline branch instead of the internal commit.
> However, I am unable to find the applied series in any of the
> repositories on git.kernel.org.
>
> On Thu, Apr 04, 2024 at 02:23:21PM +0200, Daniel Lezcano wrote:
> > On 28/03/2024 20:13, Dmitry Rokosov wrote:
> > > It is primarily based on the G12A thermal controller, with only a slight
> > > variation in the offset value of the efuse parameters. Therefore, this
> > > patch series provides appropriate platform data and dt-bindings to
> > > ensure proper support.
> >
> >
> > Applied, thanks
>
--
Thank you,
Dmitry
Hi Dmitry,
On 26/04/2024 09:31, Dmitry Rokosov wrote:
> Hello Neil,
>
> I hope you're doing well. I was wondering if you could assist me with
> below problem.
>
> I'm a bit confused about which kernel repository the series was applied
> to. I asked Daniel about it, but unfortunately, I didn't receive any
> feedback from him. Could you provide some clarification on this matter?
>
> Thank you in advance for your help.
I was OoO the last two weeks.
Your series is in my tree [1], which is pulled automatically by the
linux-pm tree in its bleeding-edge branch.
Today, this branch will move to the linux-next branch [2] which will
also be pulled by the linux-pm/next branch automatically.
Hope that helps and sorry for the delay to answer
-- Daniel
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/bleeding-edge
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/linux-next
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Hello Daniel,
On Fri, Apr 26, 2024 at 09:57:29AM +0200, Daniel Lezcano wrote:
>
> Hi Dmitry,
>
> On 26/04/2024 09:31, Dmitry Rokosov wrote:
> > Hello Neil,
> >
> > I hope you're doing well. I was wondering if you could assist me with
> > below problem.
> >
> > I'm a bit confused about which kernel repository the series was applied
> > to. I asked Daniel about it, but unfortunately, I didn't receive any
> > feedback from him. Could you provide some clarification on this matter?
> >
> > Thank you in advance for your help.
>
> I was OoO the last two weeks.
>
> Your series is in my tree [1], which is pulled automatically by the linux-pm
> tree in its bleeding-edge branch.
>
> Today, this branch will move to the linux-next branch [2] which will also be
> pulled by the linux-pm/next branch automatically.
>
> Hope that helps and sorry for the delay to answer
>
> -- Daniel
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/bleeding-edge
>
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git/log/?h=thermal/linux-next
Thanks a lot for the update! Now I see the patches in the above repos.
--
Thank you,
Dmitry