2024-05-03 08:07:11

by Thomas Huth

[permalink] [raw]
Subject: [PATCH v2] s390: Remove comment about TIF_FPU

It has been removed in commit 2c6b96762fbd ("s390/fpu: remove TIF_FPU"),
so we should not mention TIF_FPU in the comment here anymore. Since the
remaining parts of the comment just document the obvious fact that
save_user_fpu_regs() saves the FPU state, simply remove the comment now
completely.

Signed-off-by: Thomas Huth <[email protected]>
---
v2: Drop the comment completely

arch/s390/kernel/process.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/arch/s390/kernel/process.c b/arch/s390/kernel/process.c
index dd456b475861..d8740631df4b 100644
--- a/arch/s390/kernel/process.c
+++ b/arch/s390/kernel/process.c
@@ -86,11 +86,6 @@ void arch_release_task_struct(struct task_struct *tsk)

int arch_dup_task_struct(struct task_struct *dst, struct task_struct *src)
{
- /*
- * Save the floating-point or vector register state of the current
- * task and set the TIF_FPU flag to lazy restore the FPU register
- * state when returning to user space.
- */
save_user_fpu_regs();

*dst = *src;
--
2.44.0



2024-05-03 08:15:52

by Heiko Carstens

[permalink] [raw]
Subject: Re: [PATCH v2] s390: Remove comment about TIF_FPU

On Fri, May 03, 2024 at 10:06:48AM +0200, Thomas Huth wrote:
> It has been removed in commit 2c6b96762fbd ("s390/fpu: remove TIF_FPU"),
> so we should not mention TIF_FPU in the comment here anymore. Since the
> remaining parts of the comment just document the obvious fact that
> save_user_fpu_regs() saves the FPU state, simply remove the comment now
> completely.
>
> Signed-off-by: Thomas Huth <[email protected]>
> ---
> v2: Drop the comment completely
>
> arch/s390/kernel/process.c | 5 -----
> 1 file changed, 5 deletions(-)

Acked-by: Heiko Carstens <[email protected]>

2024-05-03 08:48:38

by Alexander Gordeev

[permalink] [raw]
Subject: Re: [PATCH v2] s390: Remove comment about TIF_FPU

On Fri, May 03, 2024 at 10:06:48AM +0200, Thomas Huth wrote:
> It has been removed in commit 2c6b96762fbd ("s390/fpu: remove TIF_FPU"),
> so we should not mention TIF_FPU in the comment here anymore. Since the
> remaining parts of the comment just document the obvious fact that
> save_user_fpu_regs() saves the FPU state, simply remove the comment now
> completely.
>
> Signed-off-by: Thomas Huth <[email protected]>
> ---
> v2: Drop the comment completely
>
> arch/s390/kernel/process.c | 5 -----
> 1 file changed, 5 deletions(-)

Applied, thanks!