2024-04-25 13:18:38

by Kemeng Shi

Subject: [PATCH v2 4/4] mm: remove stale comment __folio_mark_dirty

The __folio_mark_dirty will not mark inode dirty any longer. Remove the
stale comment of it.

Signed-off-by: Kemeng Shi <[email protected]>
Reviewed-by: Matthew Wilcox (Oracle) <[email protected]>
---
mm/page-writeback.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 22e1acec899e..692c0da04cbd 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -2721,8 +2721,7 @@ void folio_account_cleaned(struct folio *folio, struct bdi_writeback *wb)
}

/*
- * Mark the folio dirty, and set it dirty in the page cache, and mark
- * the inode dirty.
+ * Mark the folio dirty, and set it dirty in the page cache.
*
* If warn is true, then emit a warning if the folio is not uptodate and has
* not been truncated.
--
2.30.0

2024-05-03 09:32:18

by Jan Kara

Subject: Re: [PATCH v2 4/4] mm: remove stale comment __folio_mark_dirty

On Thu 25-04-24 21:17:24, Kemeng Shi wrote:
> The __folio_mark_dirty will not mark inode dirty any longer. Remove the
> stale comment of it.
>
> Signed-off-by: Kemeng Shi <[email protected]>
> Reviewed-by: Matthew Wilcox (Oracle) <[email protected]>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> mm/page-writeback.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 22e1acec899e..692c0da04cbd 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -2721,8 +2721,7 @@ void folio_account_cleaned(struct folio *folio, struct bdi_writeback *wb)
> }
>
> /*
> - * Mark the folio dirty, and set it dirty in the page cache, and mark
> - * the inode dirty.
> + * Mark the folio dirty, and set it dirty in the page cache.
> *
> * If warn is true, then emit a warning if the folio is not uptodate and has
> * not been truncated.
> --
> 2.30.0
>
--
Jan Kara <[email protected]>
SUSE Labs, CR