2024-05-03 18:56:45

by Angelo Dureghello

[permalink] [raw]
Subject: [PATCH] dt-bindings: iio: dac: fix ad354xr output range

From: Angelo Dureghello <[email protected]>

Fix output range, as per datasheet must be -2.5 to 7.5.

Signed-off-by: Angelo Dureghello <[email protected]>
---
Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
index 96340a05754c..8265d709094d 100644
--- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
+++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
@@ -139,7 +139,7 @@ allOf:
Voltage output range of the channel as <minimum, maximum>
Required connections:
Rfb1x for: 0 to 2.5 V; 0 to 3V; 0 to 5 V;
- Rfb2x for: 0 to 10 V; 2.5 to 7.5V; -5 to 5 V;
+ Rfb2x for: 0 to 10 V; -2.5 to 7.5V; -5 to 5 V;
oneOf:
- items:
- const: 0
--
2.45.0.rc1



2024-05-04 11:31:07

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: iio: dac: fix ad354xr output range

On Fri, 3 May 2024 20:55:28 +0200
Angelo Dureghello <[email protected]> wrote:

> From: Angelo Dureghello <[email protected]>
>
> Fix output range, as per datasheet must be -2.5 to 7.5.
>
> Signed-off-by: Angelo Dureghello <[email protected]>
> ---
When resending to add people and lists to CC, say that somewhere, or just
mark it as a v2 with the change being to increase the cc list.

Otherwise tooling and maintainers can both get confused!

Patch looks fine to me.

Jonathan

> Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> index 96340a05754c..8265d709094d 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml
> @@ -139,7 +139,7 @@ allOf:
> Voltage output range of the channel as <minimum, maximum>
> Required connections:
> Rfb1x for: 0 to 2.5 V; 0 to 3V; 0 to 5 V;
> - Rfb2x for: 0 to 10 V; 2.5 to 7.5V; -5 to 5 V;
> + Rfb2x for: 0 to 10 V; -2.5 to 7.5V; -5 to 5 V;
> oneOf:
> - items:
> - const: 0


2024-05-04 11:43:22

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: iio: dac: fix ad354xr output range

On 03/05/2024 20:55, Angelo Dureghello wrote:
> From: Angelo Dureghello <[email protected]>
>
> Fix output range, as per datasheet must be -2.5 to 7.5.
>
> Signed-off-by: Angelo Dureghello <[email protected]>
> ---

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2024-05-05 10:04:35

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: iio: dac: fix ad354xr output range

On Sat, 4 May 2024 13:43:07 +0200
Krzysztof Kozlowski <[email protected]> wrote:

> On 03/05/2024 20:55, Angelo Dureghello wrote:
> > From: Angelo Dureghello <[email protected]>
> >
> > Fix output range, as per datasheet must be -2.5 to 7.5.
> >
> > Signed-off-by: Angelo Dureghello <[email protected]>
> > ---
>
> Acked-by: Krzysztof Kozlowski <[email protected]>
>
> Best regards,
> Krzysztof
>
I added a fixes tag to the commit that introduced this doc.

Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan