2024-05-04 00:48:48

by Shenghao Ding

Subject: [PATCH v1] ALSA: ASoc/tas2781: Fix an issue reported by robot kernel test

Fix an issue reported by robot kernel test and two harmless changes.

Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver")
Signed-off-by: Shenghao Ding <[email protected]>

---
v1:
- Changed the copyright year to 2024
- tasdevice-fmw.c --> tas2781-fmwlib.c
- | Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
---
sound/soc/codecs/tas2781-fmwlib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c
index 45760fe19523..a6be81adcb83 100644
--- a/sound/soc/codecs/tas2781-fmwlib.c
+++ b/sound/soc/codecs/tas2781-fmwlib.c
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0
//
-// tasdevice-fmw.c -- TASDEVICE firmware support
+// tas2781-fmwlib.c -- TASDEVICE firmware support
//
-// Copyright 2023 Texas Instruments, Inc.
+// Copyright 2023 - 2024 Texas Instruments, Inc.
//
// Author: Shenghao Ding <[email protected]>

@@ -1878,7 +1878,7 @@ int tas2781_load_calibration(void *context, char *file_name,
{
struct tasdevice_priv *tas_priv = (struct tasdevice_priv *)context;
struct tasdevice *tasdev = &(tas_priv->tasdevice[i]);
- const struct firmware *fw_entry;
+ const struct firmware *fw_entry = NULL;
struct tasdevice_fw *tas_fmw;
struct firmware fmw;
int offset = 0;
--
2.34.1

2024-05-04 08:08:43

by Takashi Iwai

Subject: Re: [PATCH v1] ALSA: ASoc/tas2781: Fix an issue reported by robot kernel test

On Sat, 04 May 2024 02:47:03 +0200,
Shenghao Ding wrote:
>
> Fix an issue reported by robot kernel test and two harmless changes.

You need to describe more what was actually an issue reported by robot
kernel test here. Otherwise it's nothing but a voodoo magic.

Also enumerate two harmless changes, too: it's an update of copyright
year and a correction of the comments.

Last but not least, the subject suffix should be "ASoC: tas2781: ..."
(not "ASoc", and without "ALSA:")


thanks,

Takashi

>
> Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver")
> Signed-off-by: Shenghao Ding <[email protected]>
>
> ---
> v1:
> - Changed the copyright year to 2024
> - tasdevice-fmw.c --> tas2781-fmwlib.c
> - | Reported-by: kernel test robot <[email protected]>
> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> ---
> sound/soc/codecs/tas2781-fmwlib.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c
> index 45760fe19523..a6be81adcb83 100644
> --- a/sound/soc/codecs/tas2781-fmwlib.c
> +++ b/sound/soc/codecs/tas2781-fmwlib.c
> @@ -1,8 +1,8 @@
> // SPDX-License-Identifier: GPL-2.0
> //
> -// tasdevice-fmw.c -- TASDEVICE firmware support
> +// tas2781-fmwlib.c -- TASDEVICE firmware support
> //
> -// Copyright 2023 Texas Instruments, Inc.
> +// Copyright 2023 - 2024 Texas Instruments, Inc.
> //
> // Author: Shenghao Ding <[email protected]>
>
> @@ -1878,7 +1878,7 @@ int tas2781_load_calibration(void *context, char *file_name,
> {
> struct tasdevice_priv *tas_priv = (struct tasdevice_priv *)context;
> struct tasdevice *tasdev = &(tas_priv->tasdevice[i]);
> - const struct firmware *fw_entry;
> + const struct firmware *fw_entry = NULL;
> struct tasdevice_fw *tas_fmw;
> struct firmware fmw;
> int offset = 0;
> --
> 2.34.1
>