2024-05-05 20:22:41

by Dr. David Alan Gilbert

Subject: [PATCH] ARM: omap1: Remove unused struct 'dma_link_info'

From: "Dr. David Alan Gilbert" <[email protected]>

I think the last use of this was removed somewhere
around the two:
Commit 755cbfd8cf89 ("ARM: OMAP2+: Drop sdma interrupt handling for
mach-omap2")
and
Commit 16630718ee46 ("ARM: omap1: move plat/dma.c to mach/omap-dma.c")

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
arch/arm/mach-omap1/omap-dma.c | 13 -------------
1 file changed, 13 deletions(-)

diff --git a/arch/arm/mach-omap1/omap-dma.c b/arch/arm/mach-omap1/omap-dma.c
index 9ee472f8ead12..f091f78631d09 100644
--- a/arch/arm/mach-omap1/omap-dma.c
+++ b/arch/arm/mach-omap1/omap-dma.c
@@ -59,19 +59,6 @@ static struct omap_dma_dev_attr *d;
static int enable_1510_mode;
static u32 errata;

-struct dma_link_info {
- int *linked_dmach_q;
- int no_of_lchs_linked;
-
- int q_count;
- int q_tail;
- int q_head;
-
- int chain_state;
- int chain_mode;
-
-};
-
static int dma_lch_count;
static int dma_chan_count;
static int omap_dma_reserve_channels;
--
2.45.0

2024-06-03 17:41:38

by Dr. David Alan Gilbert

Subject: Re: [PATCH] ARM: omap1: Remove unused struct 'dma_link_info'

* [email protected] ([email protected]) wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> I think the last use of this was removed somewhere
> around the two:
> Commit 755cbfd8cf89 ("ARM: OMAP2+: Drop sdma interrupt handling for
> mach-omap2")
> and
> Commit 16630718ee46 ("ARM: omap1: move plat/dma.c to mach/omap-dma.c")
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Ping

> ---
> arch/arm/mach-omap1/omap-dma.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/omap-dma.c b/arch/arm/mach-omap1/omap-dma.c
> index 9ee472f8ead12..f091f78631d09 100644
> --- a/arch/arm/mach-omap1/omap-dma.c
> +++ b/arch/arm/mach-omap1/omap-dma.c
> @@ -59,19 +59,6 @@ static struct omap_dma_dev_attr *d;
> static int enable_1510_mode;
> static u32 errata;
>
> -struct dma_link_info {
> - int *linked_dmach_q;
> - int no_of_lchs_linked;
> -
> - int q_count;
> - int q_tail;
> - int q_head;
> -
> - int chain_state;
> - int chain_mode;
> -
> -};
> -
> static int dma_lch_count;
> static int dma_chan_count;
> static int omap_dma_reserve_channels;
> --
> 2.45.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/

2024-06-06 20:04:54

by Aaro Koskinen

Subject: Re: [PATCH] ARM: omap1: Remove unused struct 'dma_link_info'

Hi,

On Sun, May 05, 2024 at 09:22:14PM +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> I think the last use of this was removed somewhere
> around the two:
> Commit 755cbfd8cf89 ("ARM: OMAP2+: Drop sdma interrupt handling for
> mach-omap2")
> and
> Commit 16630718ee46 ("ARM: omap1: move plat/dma.c to mach/omap-dma.c")
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Acked-by: Aaro Koskinen <[email protected]>

> ---
> arch/arm/mach-omap1/omap-dma.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/omap-dma.c b/arch/arm/mach-omap1/omap-dma.c
> index 9ee472f8ead12..f091f78631d09 100644
> --- a/arch/arm/mach-omap1/omap-dma.c
> +++ b/arch/arm/mach-omap1/omap-dma.c
> @@ -59,19 +59,6 @@ static struct omap_dma_dev_attr *d;
> static int enable_1510_mode;
> static u32 errata;
>
> -struct dma_link_info {
> - int *linked_dmach_q;
> - int no_of_lchs_linked;
> -
> - int q_count;
> - int q_tail;
> - int q_head;
> -
> - int chain_state;
> - int chain_mode;
> -
> -};
> -
> static int dma_lch_count;
> static int dma_chan_count;
> static int omap_dma_reserve_channels;
> --
> 2.45.0
>