2024-05-06 00:40:43

by Dr. David Alan Gilbert

Subject: [PATCH] perf/x86/cstate: Remove unused struct 'perf_cstate_msr'

From: "Dr. David Alan Gilbert" <[email protected]>

This looks like it's unused since
Commit 8f2a28c5859b ("perf/x86/cstate: Use new probe function")

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
---
arch/x86/events/intel/cstate.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/events/intel/cstate.c
index 326c8cd5aa2d2..dcf3f152a2a64 100644
--- a/arch/x86/events/intel/cstate.c
+++ b/arch/x86/events/intel/cstate.c
@@ -143,12 +143,6 @@ struct cstate_model {
#define SLM_PKG_C6_USE_C7_MSR (1UL << 0)
#define KNL_CORE_C6_MSR (1UL << 1)

-struct perf_cstate_msr {
- u64 msr;
- struct perf_pmu_events_attr *attr;
-};
-
-
/* cstate_core PMU */
static struct pmu cstate_core_pmu;
static bool has_cstate_core;
--
2.45.0

2024-05-20 13:51:31

by Dr. David Alan Gilbert

Subject: Re: [PATCH] perf/x86/cstate: Remove unused struct 'perf_cstate_msr'

* [email protected] ([email protected]) wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> This looks like it's unused since
> Commit 8f2a28c5859b ("perf/x86/cstate: Use new probe function")
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>

Ping

> ---
> arch/x86/events/intel/cstate.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/x86/events/intel/cstate.c b/arch/x86/events/intel/cstate.c
> index 326c8cd5aa2d2..dcf3f152a2a64 100644
> --- a/arch/x86/events/intel/cstate.c
> +++ b/arch/x86/events/intel/cstate.c
> @@ -143,12 +143,6 @@ struct cstate_model {
> #define SLM_PKG_C6_USE_C7_MSR (1UL << 0)
> #define KNL_CORE_C6_MSR (1UL << 1)
>
> -struct perf_cstate_msr {
> - u64 msr;
> - struct perf_pmu_events_attr *attr;
> -};
> -
> -
> /* cstate_core PMU */
> static struct pmu cstate_core_pmu;
> static bool has_cstate_core;
> --
> 2.45.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/