Subject: [PATCH net-next] ax25: Remove superfuous "return" from ax25_ds_set_timer

From: Joel Granados <[email protected]>

Remove the explicit call to "return" in the void ax25_ds_set_timer
function that was introduced in 78a7b5dbc060 ("ax.25: x.25: Remove the
now superfluous sentinel elements from ctl_table array").

Signed-off-by: Joel Granados <[email protected]>
---
I did not include a "Fixes:" tag as this (IMO) should not be backported
into a stable kernel. I'm assuming that net-next is going to be merged
into mainline as is and therefore I linked to a specific commit ID (get
back to me if I should do something different)

This comes after a review from Dave Carpenter [1] to an already accepted
patchset [2]

[1] https://lore.kernel.org/all/[email protected]
[2] https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/
---
net/ax25/ax25_ds_timer.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/ax25/ax25_ds_timer.c b/net/ax25/ax25_ds_timer.c
index c50a58d9e368..c4f8adbf8144 100644
--- a/net/ax25/ax25_ds_timer.c
+++ b/net/ax25/ax25_ds_timer.c
@@ -55,7 +55,6 @@ void ax25_ds_set_timer(ax25_dev *ax25_dev)
ax25_dev->dama.slave_timeout =
msecs_to_jiffies(ax25_dev->values[AX25_VALUES_DS_TIMEOUT]) / 10;
mod_timer(&ax25_dev->dama.slave_timer, jiffies + HZ);
- return;
}

/*

---
base-commit: 179a6f5df8dab7d027aa73a302d8506c6533e463
change-id: 20240507-jag-fix_void_ret_ax25-c78105dcdf79

Best regards,
--
Joel Granados <[email protected]>




2024-05-08 11:32:04

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net-next] ax25: Remove superfuous "return" from ax25_ds_set_timer

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Tue, 07 May 2024 10:40:39 +0200 you wrote:
> From: Joel Granados <[email protected]>
>
> Remove the explicit call to "return" in the void ax25_ds_set_timer
> function that was introduced in 78a7b5dbc060 ("ax.25: x.25: Remove the
> now superfluous sentinel elements from ctl_table array").
>
> Signed-off-by: Joel Granados <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] ax25: Remove superfuous "return" from ax25_ds_set_timer
https://git.kernel.org/netdev/net-next/c/1d3985ed0dd3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html