2024-05-07 17:16:26

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v4 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings

On Tue, May 07, 2024 at 09:52:28PM +0800, Cong Yang wrote:
> In V1, discussed with Doug and Linus [1], we need break out as separate
> driver for the himax83102-j02 controller. Beacuse "starry,himax83102-j02"
> and in this series "BOE nv110wum-l60" "IVO t109nw41" panels use same
> controller, they have some common CMDS. So add new documentation for
> this panels.
>
> For himax83102-j02 controller, no need 3v3 supply, so remove it.
>
> [1]: https://lore.kernel.org/all/CACRpkdbzYZAS0=zBQJUC4CB2wj4s1h6n6aSAZQvdMV95r3zRUw@mail.gmail.com
>
> Signed-off-by: Cong Yang <[email protected]>

Other than the issue Rob's bot reported, this looks fine to me.

Thanks for the updates - but please test your bindings!
Conor.


Attachments:
(No filename) (760.00 B)
signature.asc (235.00 B)
Download all attachments