2024-05-07 10:40:09

by Illia Ostapyshyn

Subject: [PATCH v2] docs: cgroup-v1: Update page cache removal functions

Commit 452e9e6992fe ("filemap: Add filemap_remove_folio and
__filemap_remove_folio") reimplemented __delete_from_page_cache() as
__filemap_remove_folio() and delete_from_page_cache() as
filemap_remove_folio(). The compatibility wrappers were finally removed
in ece62684dcfb ("hugetlbfs: convert hugetlb_delete_from_page_cache() to
use folios") and 6ffcd825e7d0 ("mm: Remove __delete_from_page_cache()").

Update the remaining references to dead functions in the memcg
implementation memo.

Signed-off-by: Illia Ostapyshyn <[email protected]>
---

Changes in v2:
* filemap_free_folio() was meant to be filemap_remove_folio(). Sorry.

Documentation/admin-guide/cgroup-v1/memcg_test.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/admin-guide/cgroup-v1/memcg_test.rst b/Documentation/admin-guide/cgroup-v1/memcg_test.rst
index 1f128458ddea..9f8e27355cba 100644
--- a/Documentation/admin-guide/cgroup-v1/memcg_test.rst
+++ b/Documentation/admin-guide/cgroup-v1/memcg_test.rst
@@ -102,7 +102,7 @@ Under below explanation, we assume CONFIG_SWAP=y.
The logic is very clear. (About migration, see below)

Note:
- __remove_from_page_cache() is called by remove_from_page_cache()
+ __filemap_remove_folio() is called by filemap_remove_folio()
and __remove_mapping().

6. Shmem(tmpfs) Page Cache
--
2.39.2

2024-05-13 17:06:51

by Tejun Heo

Subject: Re: [PATCH v2] docs: cgroup-v1: Update page cache removal functions

On Tue, May 07, 2024 at 12:34:27PM +0200, Illia Ostapyshyn wrote:
> Commit 452e9e6992fe ("filemap: Add filemap_remove_folio and
> __filemap_remove_folio") reimplemented __delete_from_page_cache() as
> __filemap_remove_folio() and delete_from_page_cache() as
> filemap_remove_folio(). The compatibility wrappers were finally removed
> in ece62684dcfb ("hugetlbfs: convert hugetlb_delete_from_page_cache() to
> use folios") and 6ffcd825e7d0 ("mm: Remove __delete_from_page_cache()").
>
> Update the remaining references to dead functions in the memcg
> implementation memo.
>
> Signed-off-by: Illia Ostapyshyn <[email protected]>

Applied to cgroup/for-6.10.

Thanks.

--
tejun