2024-05-07 10:49:41

by Uwe Kleine-König

[permalink] [raw]
Subject: [PATCH] regulator: Mention regulator id in error message about dummy supplies

With the name that is currently looked up it is considerably easier to
understand the issue and fix the warning.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/regulator/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index dabac9772741..30f8e46dacdd 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2195,7 +2195,7 @@ struct regulator *_regulator_get(struct device *dev, const char *id,

if (!have_full_constraints()) {
dev_warn(dev,
- "incomplete constraints, dummy supplies not allowed\n");
+ "incomplete constraints, dummy supplies not allowed (id=%s)\n", id);
return ERR_PTR(-ENODEV);
}

@@ -2213,7 +2213,7 @@ struct regulator *_regulator_get(struct device *dev, const char *id,

case EXCLUSIVE_GET:
dev_warn(dev,
- "dummy supplies not allowed for exclusive requests\n");
+ "dummy supplies not allowed for exclusive requests (id=%s)\n", id);
fallthrough;

default:

base-commit: 93a39e4766083050ca0ecd6a3548093a3b9eb60c
--
2.43.0



2024-05-08 11:45:46

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: Mention regulator id in error message about dummy supplies

On Tue, 07 May 2024 12:47:02 +0200, Uwe Kleine-König wrote:
> With the name that is currently looked up it is considerably easier to
> understand the issue and fix the warning.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: Mention regulator id in error message about dummy supplies
commit: 75c48adfe9b16fc5a468ef4cec4e87a1418c3ed8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark