2024-05-08 22:29:39

by Steven 'Steve' Kendall

[permalink] [raw]
Subject: [PATCH] ALSA: usb-audio: Add name for HP Engage Go dock

This dock previously presented as 'generic USB Audio'.
UCM may now be applied specific to this dock.

Signed-off-by: Steven 'Steve' Kendall <[email protected]>
---
sound/usb/card.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/sound/usb/card.c b/sound/usb/card.c
index 1b2edc0fd2e9..bdb04fa37a71 100644
--- a/sound/usb/card.c
+++ b/sound/usb/card.c
@@ -425,6 +425,10 @@ static const struct usb_audio_device_name usb_audio_names[] = {

DEVICE_NAME(0x0fd9, 0x0008, "Hauppauge", "HVR-950Q"),

+ /* Dock/Stand for HP Engage Go */
+ PROFILE_NAME(0x103c, 0x830a, "HP", "HP Engage Go Dock",
+ "HP-Engage-Go-Dock"),
+
/* Stanton/N2IT Final Scratch v1 device ('Scratchamp') */
DEVICE_NAME(0x103d, 0x0100, "Stanton", "ScratchAmp"),
DEVICE_NAME(0x103d, 0x0101, "Stanton", "ScratchAmp"),

---
base-commit: dd5a440a31fae6e459c0d6271dddd62825505361
change-id: 20240508-usb-audio-hp-engage-go-dock-50b629480a9b

Best regards,
--
Steven 'Steve' Kendall <[email protected]>



2024-05-09 08:14:09

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH] ALSA: usb-audio: Add name for HP Engage Go dock

On Thu, 09 May 2024 00:29:25 +0200,
Steven 'Steve' Kendall wrote:
>
> This dock previously presented as 'generic USB Audio'.
> UCM may now be applied specific to this dock.
>
> Signed-off-by: Steven 'Steve' Kendall <[email protected]>

Thanks, applied now to for-next branch.


Takashi

2024-05-09 11:21:05

by Jaroslav Kysela

[permalink] [raw]
Subject: Re: [PATCH] ALSA: usb-audio: Add name for HP Engage Go dock

On 09. 05. 24 10:14, Takashi Iwai wrote:
> On Thu, 09 May 2024 00:29:25 +0200,
> Steven 'Steve' Kendall wrote:
>>
>> This dock previously presented as 'generic USB Audio'.
>> UCM may now be applied specific to this dock.
>>
>> Signed-off-by: Steven 'Steve' Kendall <[email protected]>
>
> Thanks, applied now to for-next branch.

The upstream UCM v2 does not use those indentifiers any more for several years
(the USB ID identifier from the mixer components string is used). I would not
accept such patches further. Thank you.

Jaroslav

--
Jaroslav Kysela <[email protected]>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.