2024-05-07 09:20:28

by Lukasz Majewski

[permalink] [raw]
Subject: [net-next PATCH] test: hsr: Call cleanup_all_ns when hsr_redbox.sh script exits

Without this change the created netns instances are not cleared after
this script execution. To fix this problem the cleanup_all_ns function
from ../lib.sh is called.

Signed-off-by: Lukasz Majewski <[email protected]>
---
tools/testing/selftests/net/hsr/hsr_redbox.sh | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/net/hsr/hsr_redbox.sh b/tools/testing/selftests/net/hsr/hsr_redbox.sh
index 52e0412c32e6..db69be95ecb3 100755
--- a/tools/testing/selftests/net/hsr/hsr_redbox.sh
+++ b/tools/testing/selftests/net/hsr/hsr_redbox.sh
@@ -86,6 +86,8 @@ setup_hsr_interfaces()
check_prerequisites
setup_ns ns1 ns2 ns3

+trap cleanup_all_ns EXIT
+
setup_hsr_interfaces 1
do_complete_ping_test

--
2.20.1



2024-05-08 09:23:38

by Simon Horman

[permalink] [raw]
Subject: Re: [net-next PATCH] test: hsr: Call cleanup_all_ns when hsr_redbox.sh script exits

On Tue, May 07, 2024 at 11:11:55AM +0200, Lukasz Majewski wrote:
> Without this change the created netns instances are not cleared after
> this script execution. To fix this problem the cleanup_all_ns function
> from ../lib.sh is called.
>
> Signed-off-by: Lukasz Majewski <[email protected]>

Reviewed-by: Simon Horman <[email protected]>


2024-05-08 11:32:05

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [net-next PATCH] test: hsr: Call cleanup_all_ns when hsr_redbox.sh script exits

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Tue, 7 May 2024 11:11:55 +0200 you wrote:
> Without this change the created netns instances are not cleared after
> this script execution. To fix this problem the cleanup_all_ns function
> from ../lib.sh is called.
>
> Signed-off-by: Lukasz Majewski <[email protected]>
> ---
> tools/testing/selftests/net/hsr/hsr_redbox.sh | 2 ++
> 1 file changed, 2 insertions(+)

Here is the summary with links:
- [net-next] test: hsr: Call cleanup_all_ns when hsr_redbox.sh script exits
https://git.kernel.org/netdev/net-next/c/252aa6d53931

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html