2024-05-06 08:22:25

by Takashi Sakamoto

Subject: [PATCH] firewire: core: remove flag and width from u64 formats of tracepoints events

The pointer to fw_packet structure is passed to ring buffer of tracepoints
framework as the value of u64 type. '0x%016llx' is used for the print
format of value, while the flag and width are useless in the case.

This commit removes them.

Signed-off-by: Takashi Sakamoto <[email protected]>
---
include/trace/events/firewire.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/trace/events/firewire.h b/include/trace/events/firewire.h
index 4163959be57a..cd6931b134ee 100644
--- a/include/trace/events/firewire.h
+++ b/include/trace/events/firewire.h
@@ -221,7 +221,7 @@ TRACE_EVENT(async_phy_outbound_initiate,
__entry->second_quadlet = second_quadlet
),
TP_printk(
- "packet=0x%016llx generation=%u first_quadlet=0x%08x second_quadlet=0x%08x",
+ "packet=0x%llx generation=%u first_quadlet=0x%08x second_quadlet=0x%08x",
__entry->packet,
__entry->generation,
__entry->first_quadlet,
@@ -245,7 +245,7 @@ TRACE_EVENT(async_phy_outbound_complete,
__entry->timestamp = timestamp;
),
TP_printk(
- "packet=0x%016llx generation=%u status=%u timestamp=0x%04x",
+ "packet=0x%llx generation=%u status=%u timestamp=0x%04x",
__entry->packet,
__entry->generation,
__entry->status,
@@ -273,7 +273,7 @@ TRACE_EVENT(async_phy_inbound,
__entry->second_quadlet = second_quadlet
),
TP_printk(
- "packet=0x%016llx generation=%u status=%u timestamp=0x%04x first_quadlet=0x%08x second_quadlet=0x%08x",
+ "packet=0x%llx generation=%u status=%u timestamp=0x%04x first_quadlet=0x%08x second_quadlet=0x%08x",
__entry->packet,
__entry->generation,
__entry->status,
--
2.43.0

2024-05-08 10:04:48

by Takashi Sakamoto

Subject: Re: [PATCH] firewire: core: remove flag and width from u64 formats of tracepoints events

On Mon, May 06, 2024 at 05:21:54PM +0900, Takashi Sakamoto wrote:
> The pointer to fw_packet structure is passed to ring buffer of tracepoints
> framework as the value of u64 type. '0x%016llx' is used for the print
> format of value, while the flag and width are useless in the case.
>
> This commit removes them.
>
> Signed-off-by: Takashi Sakamoto <[email protected]>
> ---
> include/trace/events/firewire.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/trace/events/firewire.h b/include/trace/events/firewire.h
> index 4163959be57a..cd6931b134ee 100644
> --- a/include/trace/events/firewire.h
> +++ b/include/trace/events/firewire.h
> @@ -221,7 +221,7 @@ TRACE_EVENT(async_phy_outbound_initiate,
> __entry->second_quadlet = second_quadlet
> ),
> TP_printk(
> - "packet=0x%016llx generation=%u first_quadlet=0x%08x second_quadlet=0x%08x",
> + "packet=0x%llx generation=%u first_quadlet=0x%08x second_quadlet=0x%08x",
> __entry->packet,
> __entry->generation,
> __entry->first_quadlet,
> @@ -245,7 +245,7 @@ TRACE_EVENT(async_phy_outbound_complete,
> __entry->timestamp = timestamp;
> ),
> TP_printk(
> - "packet=0x%016llx generation=%u status=%u timestamp=0x%04x",
> + "packet=0x%llx generation=%u status=%u timestamp=0x%04x",
> __entry->packet,
> __entry->generation,
> __entry->status,
> @@ -273,7 +273,7 @@ TRACE_EVENT(async_phy_inbound,
> __entry->second_quadlet = second_quadlet
> ),
> TP_printk(
> - "packet=0x%016llx generation=%u status=%u timestamp=0x%04x first_quadlet=0x%08x second_quadlet=0x%08x",
> + "packet=0x%llx generation=%u status=%u timestamp=0x%04x first_quadlet=0x%08x second_quadlet=0x%08x",
> __entry->packet,
> __entry->generation,
> __entry->status,
> --
> 2.43.0

Applied to for-next branch.


Regards

Takashi Sakamoto