2024-05-08 10:54:07

by Takashi Sakamoto

Subject: [PATCH] firewire: obsolete usage of *-objs in Makefile for KUnit test

Nowadays *-objs list is just for user space programs.

This commit obsolete the usage, and simplify Makefile for firewire KUnit
tests since the tests are not composite objects.

Signed-off-by: Takashi Sakamoto <[email protected]>
---
drivers/firewire/Makefile | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/firewire/Makefile b/drivers/firewire/Makefile
index 013e1f2641bd..75c47d046925 100644
--- a/drivers/firewire/Makefile
+++ b/drivers/firewire/Makefile
@@ -16,8 +16,5 @@ obj-$(CONFIG_FIREWIRE_NET) += firewire-net.o
obj-$(CONFIG_FIREWIRE_NOSY) += nosy.o
obj-$(CONFIG_PROVIDE_OHCI1394_DMA_INIT) += init_ohci1394_dma.o

-firewire-uapi-test-objs += uapi-test.o
-firewire-packet-serdes-test-objs += packet-serdes-test.o
-
-obj-$(CONFIG_FIREWIRE_KUNIT_UAPI_TEST) += firewire-uapi-test.o
-obj-$(CONFIG_FIREWIRE_KUNIT_PACKET_SERDES_TEST) += firewire-packet-serdes-test.o
+obj-$(CONFIG_FIREWIRE_KUNIT_UAPI_TEST) += uapi-test.o
+obj-$(CONFIG_FIREWIRE_KUNIT_PACKET_SERDES_TEST) += packet-serdes-test.o
--
2.43.0

2024-05-08 23:22:40

by Takashi Sakamoto

Subject: Re: [PATCH] firewire: obsolete usage of *-objs in Makefile for KUnit test

On Wed, May 08, 2024 at 07:53:51PM +0900, Takashi Sakamoto wrote:
> Nowadays *-objs list is just for user space programs.
>
> This commit obsolete the usage, and simplify Makefile for firewire KUnit
> tests since the tests are not composite objects.
>
> Signed-off-by: Takashi Sakamoto <[email protected]>
> ---
> drivers/firewire/Makefile | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/firewire/Makefile b/drivers/firewire/Makefile
> index 013e1f2641bd..75c47d046925 100644
> --- a/drivers/firewire/Makefile
> +++ b/drivers/firewire/Makefile
> @@ -16,8 +16,5 @@ obj-$(CONFIG_FIREWIRE_NET) += firewire-net.o
> obj-$(CONFIG_FIREWIRE_NOSY) += nosy.o
> obj-$(CONFIG_PROVIDE_OHCI1394_DMA_INIT) += init_ohci1394_dma.o
>
> -firewire-uapi-test-objs += uapi-test.o
> -firewire-packet-serdes-test-objs += packet-serdes-test.o
> -
> -obj-$(CONFIG_FIREWIRE_KUNIT_UAPI_TEST) += firewire-uapi-test.o
> -obj-$(CONFIG_FIREWIRE_KUNIT_PACKET_SERDES_TEST) += firewire-packet-serdes-test.o
> +obj-$(CONFIG_FIREWIRE_KUNIT_UAPI_TEST) += uapi-test.o
> +obj-$(CONFIG_FIREWIRE_KUNIT_PACKET_SERDES_TEST) += packet-serdes-test.o
> --
> 2.43.0

Applied to for-next branch.


Regards

Takashi Sakamoto