2024-05-09 12:50:35

by Yu Kuai

Subject: [PATCH RESEND for-6.10/block] block: add plug while submitting IO

From: Yu Kuai <[email protected]>

So that if caller didn't use plug, for example, __blkdev_direct_IO_simple()
and __blkdev_direct_IO_async(), block layer can still benefit from caching
nsec time in the plug.

Signed-off-by: Yu Kuai <[email protected]>
---
block/blk-core.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/block/blk-core.c b/block/blk-core.c
index 9ead80d6c6f0..8566bbd8aeba 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -646,11 +646,13 @@ static void __submit_bio(struct bio *bio)
static void __submit_bio_noacct(struct bio *bio)
{
struct bio_list bio_list_on_stack[2];
+ struct blk_plug plug;

BUG_ON(bio->bi_next);

bio_list_init(&bio_list_on_stack[0]);
current->bio_list = bio_list_on_stack;
+ blk_start_plug(&plug);

do {
struct request_queue *q = bdev_get_queue(bio->bi_bdev);
@@ -684,19 +686,23 @@ static void __submit_bio_noacct(struct bio *bio)
bio_list_merge(&bio_list_on_stack[0], &bio_list_on_stack[1]);
} while ((bio = bio_list_pop(&bio_list_on_stack[0])));

+ blk_finish_plug(&plug);
current->bio_list = NULL;
}

static void __submit_bio_noacct_mq(struct bio *bio)
{
struct bio_list bio_list[2] = { };
+ struct blk_plug plug;

current->bio_list = bio_list;
+ blk_start_plug(&plug);

do {
__submit_bio(bio);
} while ((bio = bio_list_pop(&bio_list[0])));

+ blk_finish_plug(&plug);
current->bio_list = NULL;
}

--
2.39.2

2024-05-09 14:03:07

by Jens Axboe

Subject: Re: [PATCH RESEND for-6.10/block] block: add plug while submitting IO

On Thu, 09 May 2024 20:38:25 +0800, Yu Kuai wrote:
> So that if caller didn't use plug, for example, __blkdev_direct_IO_simple()
> and __blkdev_direct_IO_async(), block layer can still benefit from caching
> nsec time in the plug.
>
>

Applied, thanks!

[1/1] block: add plug while submitting IO
commit: 060406c61c7cb4bbd82a02d179decca9c9bb3443

Best regards,
--
Jens Axboe