2024-05-10 01:25:40

by Eric Biggers

[permalink] [raw]
Subject: Re: [PATCH v16 7/9] f2fs: Log error when lookup of encoded dentry fails

On Fri, Apr 05, 2024 at 03:13:30PM +0300, Eugen Hristev wrote:
> If the volume is in strict mode, generi c_ci_compare can report a broken
> encoding name. This will not trigger on a bad lookup, which is caught
> earlier, only if the actual disk name is bad.
>
> Suggested-by: Gabriel Krisman Bertazi <[email protected]>
> Signed-off-by: Eugen Hristev <[email protected]>
> ---
> fs/f2fs/dir.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>

Reviewed-by: Eric Biggers <[email protected]>

But please fix the typo: "generi c_ci_compare" => "generic_ci_d_compare"

- Eric