2024-05-11 02:16:28

by Jiapeng Chong

Subject: [PATCH] tulip: eeprom: clean up some inconsistent indenting

No functional modification involved.

drivers/net/ethernet/dec/tulip/eeprom.c:179 tulip_parse_eeprom() warn: inconsistent indenting.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9001
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/net/ethernet/dec/tulip/eeprom.c | 37 +++++++++++++------------
1 file changed, 19 insertions(+), 18 deletions(-)

diff --git a/drivers/net/ethernet/dec/tulip/eeprom.c b/drivers/net/ethernet/dec/tulip/eeprom.c
index d5657ff15e3c..738c01d859cf 100644
--- a/drivers/net/ethernet/dec/tulip/eeprom.c
+++ b/drivers/net/ethernet/dec/tulip/eeprom.c
@@ -175,25 +175,26 @@ void tulip_parse_eeprom(struct net_device *dev)
dev->name);
return;
}
- /* Do a fix-up based on the vendor half of the station address prefix. */
- for (i = 0; eeprom_fixups[i].name; i++) {
- if (dev->dev_addr[0] == eeprom_fixups[i].addr0 &&
- dev->dev_addr[1] == eeprom_fixups[i].addr1 &&
- dev->dev_addr[2] == eeprom_fixups[i].addr2) {
- if (dev->dev_addr[2] == 0xE8 && ee_data[0x1a] == 0x55)
- i++; /* An Accton EN1207, not an outlaw Maxtech. */
- memcpy(ee_data + 26, eeprom_fixups[i].newtable,
- sizeof(eeprom_fixups[i].newtable));
- pr_info("%s: Old format EEPROM on '%s' board. Using substitute media control info\n",
- dev->name, eeprom_fixups[i].name);
- break;
+ /* Do a fix-up based on the vendor half of the station address prefix. */
+ for (i = 0; eeprom_fixups[i].name; i++) {
+ if (dev->dev_addr[0] == eeprom_fixups[i].addr0 &&
+ dev->dev_addr[1] == eeprom_fixups[i].addr1 &&
+ dev->dev_addr[2] == eeprom_fixups[i].addr2) {
+ if (dev->dev_addr[2] == 0xE8 && ee_data[0x1a] == 0x55)
+ i++; /* An Accton EN1207, not an outlaw Maxtech. */
+ memcpy(ee_data + 26, eeprom_fixups[i].newtable,
+ sizeof(eeprom_fixups[i].newtable));
+ pr_info("%s: Old format EEPROM on '%s' board. Using substitute media control info\n",
+ dev->name, eeprom_fixups[i].name);
+ break;
+ }
+ }
+ /* No fixup found. */
+ if (!eeprom_fixups[i].name) {
+ pr_info("%s: Old style EEPROM with no media selection information\n",
+ dev->name);
+ return;
}
- }
- if (eeprom_fixups[i].name == NULL) { /* No fixup found. */
- pr_info("%s: Old style EEPROM with no media selection information\n",
- dev->name);
- return;
- }
}

controller_index = 0;
--
2.20.1.7.g153144c

2024-05-13 14:45:52

by Jakub Kicinski

Subject: Re: [PATCH] tulip: eeprom: clean up some inconsistent indenting

On Sat, 11 May 2024 10:14:48 +0800 Jiapeng Chong wrote:
> No functional modification involved.
>
> drivers/net/ethernet/dec/tulip/eeprom.c:179 tulip_parse_eeprom() warn: inconsistent indenting.

We don't accept pure formatting or checkpatch "fixes" in networking.
Especially for ancient HW.
--
pw-bot: reject