2024-05-11 17:41:32

by Simon Horman

[permalink] [raw]
Subject: Re: [net PATCH v5 2/2] net: stmmac: move the EST structure to struct stmmac_priv

On Fri, May 10, 2024 at 08:21:55PM +0800, Xiaolei Wang wrote:
> Move the EST structure to struct stmmac_priv, because the
> EST configs don't look like platform config, but EST is
> enabled in runtime with the settings retrieved for the TC
> TAPRIO feature also in runtime. So it's better to have the
> EST-data preserved in the driver private data instead of
> the platform data storage.
>
> Signed-off-by: Xiaolei Wang <[email protected]>

Patch 1/2 of this series is a fix for net, with a Fixes tag.
IMHO, it looks good.

This patch, however, is a clean-up/enhancement.
It doesn't have a Fixes tag, which is good.
But I think it should be targeted at net-next
(once patch 1/2 has been accepted into net, and
net has been merged into net-next; also, given the timing,
once net-next reopens as It's likely to close rather soon
for the merge window).

Perhaps it is possible for the maintainers to pick up
patch 1/2, leaving this patch as follow-up.

The above notwithstanding, this patch looks good to me.

Reviewed-by: Simon Horman <[email protected]>

--
pw-bot: under-review