2024-05-13 11:46:03

by Ravi Gunasekaran

[permalink] [raw]
Subject: [PATCH v2 0/3] arm64: dts: ti: Add USB support for J722S EVM

J722S has two USB instances. This series enables USB support for
both instances.

Change log:
----------
Changes since v1:
----------------
* Introduced k3-j722s-main.dtsi newly to add the main domain
peripherals that are present additionally in J722S as suggested by
Andrew Davis

* Used generic node names as suggested by Roger Quadros

* Removed the aliases for usb as suggested by Rob Herring

v1: https://lore.kernel.org/all/[email protected]/

Ravi Gunasekaran (3):
arm64: dts: ti: k3-j722s-main: Add support for SERDES0
arm64: dts: ti: k3-j722s-main: Redefine USB1 node description
arm64: dts: ti: k3-j722s-evm: Update USB0 and USB1

arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 55 ++++++++++++
arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 103 ++++++++++++++++++++++
arch/arm64/boot/dts/ti/k3-j722s.dtsi | 5 ++
arch/arm64/boot/dts/ti/k3-serdes.h | 7 ++
4 files changed, 170 insertions(+)
create mode 100644 arch/arm64/boot/dts/ti/k3-j722s-main.dtsi

--
2.17.1



2024-05-13 11:46:29

by Ravi Gunasekaran

[permalink] [raw]
Subject: [PATCH v2 3/3] arm64: dts: ti: k3-j722s-evm: Update USB0 and USB1

The GPIO expander on the EVM allows the USB selection for Type-C
port to either USB0 or USB1 via USB hub. By default, let the Type-C
port select USB0 via the GPIO expander port P05.

Enable super-speed on USB1 by updating SerDes0 lane configuration.

Signed-off-by: Ravi Gunasekaran <[email protected]>
---
Changes since v1:
----------------
* Removed USB aliases, line-name property for p05 GPIO hog

* Included k3-j722s-main.dtsi

v1: https://lore.kernel.org/all/[email protected]/

arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 55 +++++++++++++++++++++++++
arch/arm64/boot/dts/ti/k3-j722s.dtsi | 5 +++
arch/arm64/boot/dts/ti/k3-serdes.h | 7 ++++
3 files changed, 67 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
index bf3c246d13d1..531912be97c9 100644
--- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
@@ -9,7 +9,9 @@
/dts-v1/;

#include <dt-bindings/net/ti-dp83867.h>
+#include <dt-bindings/phy/phy.h>
#include "k3-j722s.dtsi"
+#include "k3-serdes.h"

/ {
compatible = "ti,j722s-evm", "ti,j722s";
@@ -202,6 +204,12 @@
J722S_IOPAD(0x012c, PIN_OUTPUT, 0) /* (AF25) RGMII1_TX_CTL */
>;
};
+
+ main_usb1_pins_default: main-usb1-default-pins {
+ pinctrl-single,pins = <
+ J722S_IOPAD(0x0258, PIN_INPUT, 0) /* (B27) USB1_DRVVBUS */
+ >;
+ };
};

&cpsw3g {
@@ -301,6 +309,13 @@
"PCIe0_1L_RC_RSTz", "PCIe0_1L_PRSNT#",
"ENET1_EXP_SPARE2", "ENET1_EXP_PWRDN",
"PD_I2ENET1_I2CMUX_SELC_IRQ", "ENET1_EXP_RESETZ";
+
+ p05-hog {
+ /* P05 - USB2.0_MUX_SEL */
+ gpio-hog;
+ gpios = <5 GPIO_ACTIVE_LOW>;
+ output-high;
+ };
};
};

@@ -384,3 +399,43 @@
status = "okay";
bootph-all;
};
+
+&serdes0_ln_ctrl {
+ idle-states = <J722S_SERDES0_LANE0_USB>,
+ <J722S_SERDES1_LANE0_PCIE0_LANE0>;
+};
+
+&serdes0 {
+ status = "okay";
+ serdes0_usb_link: phy@0 {
+ reg = <0>;
+ cdns,num-lanes = <1>;
+ #phy-cells = <0>;
+ cdns,phy-type = <PHY_TYPE_USB3>;
+ resets = <&serdes_wiz0 1>;
+ };
+};
+
+&usbss0 {
+ ti,vbus-divider;
+ status = "okay";
+};
+
+&usb0 {
+ dr_mode = "otg";
+ usb-role-switch;
+};
+
+&usbss1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&main_usb1_pins_default>;
+ ti,vbus-divider;
+ status = "okay";
+};
+
+&usb1 {
+ dr_mode = "host";
+ maximum-speed = "super-speed";
+ phys = <&serdes0_usb_link>;
+ phy-names = "cdns3,usb3-phy";
+};
diff --git a/arch/arm64/boot/dts/ti/k3-j722s.dtsi b/arch/arm64/boot/dts/ti/k3-j722s.dtsi
index c75744edb143..61b64fae1bf4 100644
--- a/arch/arm64/boot/dts/ti/k3-j722s.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j722s.dtsi
@@ -87,3 +87,8 @@
reg = <0x00 0x70000000 0x00 0x40000>;
ranges = <0x00 0x00 0x70000000 0x40000>;
};
+
+/* Include bus peripherals that are additionally
+ * present in J722S
+ */
+ #include "k3-j722s-main.dtsi"
diff --git a/arch/arm64/boot/dts/ti/k3-serdes.h b/arch/arm64/boot/dts/ti/k3-serdes.h
index a011ad893b44..9082abeddcb1 100644
--- a/arch/arm64/boot/dts/ti/k3-serdes.h
+++ b/arch/arm64/boot/dts/ti/k3-serdes.h
@@ -201,4 +201,11 @@
#define J784S4_SERDES4_LANE3_USB 0x2
#define J784S4_SERDES4_LANE3_IP4_UNUSED 0x3

+/* J722S */
+#define J722S_SERDES0_LANE0_USB 0x0
+#define J722S_SERDES0_LANE0_QSGMII_LANE2 0x1
+
+#define J722S_SERDES1_LANE0_PCIE0_LANE0 0x0
+#define J722S_SERDES1_LANE0_QSGMII_LANE1 0x1
+
#endif /* DTS_ARM64_TI_K3_SERDES_H */
--
2.17.1


2024-05-24 05:44:38

by Siddharth Vadapalli

[permalink] [raw]
Subject: Re: [PATCH v2 3/3] arm64: dts: ti: k3-j722s-evm: Update USB0 and USB1

On Mon, May 13, 2024 at 05:14:43PM +0530, Ravi Gunasekaran wrote:
> The GPIO expander on the EVM allows the USB selection for Type-C
> port to either USB0 or USB1 via USB hub. By default, let the Type-C
> port select USB0 via the GPIO expander port P05.
>
> Enable super-speed on USB1 by updating SerDes0 lane configuration.
>
> Signed-off-by: Ravi Gunasekaran <[email protected]>
> ---
>

[...]

> @@ -384,3 +399,43 @@
> status = "okay";
> bootph-all;
> };
> +
> +&serdes0_ln_ctrl {
> + idle-states = <J722S_SERDES0_LANE0_USB>,
> + <J722S_SERDES1_LANE0_PCIE0_LANE0>;

Patch 1/3 only added the Mux for Serdes0. So the idle-states property
for Serdes1 is incorrect and should be dropped.

[...]

Regards,
Siddharth.