This patch series updates a number of Kconfig entries such that enable
ARCH_BCM2835 guarantees that essential drivers are also enabled, saves a
lot of configuration and troubleshooting time for when they are not.
Florian Fainelli (3):
mailbox: Make BCM2835_MBOX default to ARCH_BCM2835
firmware: Default RASPBERRYPI_FIRMWARE to ARCH_BCM2835
clk: bcm: Make CLK_RASPBERRYPI default to RASPBERRYPI_FIRMWARE
drivers/clk/bcm/Kconfig | 1 +
drivers/firmware/Kconfig | 1 +
drivers/mailbox/Kconfig | 1 +
3 files changed, 3 insertions(+)
--
2.34.1
The clock driver is essential in providing clocks for UARTs and other
peripherals, make it enabled by default.
Signed-off-by: Florian Fainelli <[email protected]>
---
drivers/clk/bcm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig
index a972d763eb77..90e7bab851ae 100644
--- a/drivers/clk/bcm/Kconfig
+++ b/drivers/clk/bcm/Kconfig
@@ -106,6 +106,7 @@ config CLK_BCM_SR
config CLK_RASPBERRYPI
tristate "Raspberry Pi firmware based clock support"
depends on RASPBERRYPI_FIRMWARE || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE)
+ default RASPBERRYPI_FIRMWARE
help
Enable common clock framework support for Raspberry Pi's firmware
dependent clocks
--
2.34.1
The firmware driver provides the communication interface for a number of
other essential drivers, including a clock provider.
Signed-off-by: Florian Fainelli <[email protected]>
---
drivers/firmware/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index 71d8b26c4103..ae9b28703165 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -116,6 +116,7 @@ config ISCSI_IBFT
config RASPBERRYPI_FIRMWARE
tristate "Raspberry Pi Firmware Driver"
depends on BCM2835_MBOX
+ default ARCH_BCM2835
help
This option enables support for communicating with the firmware on the
Raspberry Pi.
--
2.34.1
This driver is depended on by CONFIG_FIRMWARE_RASPBERRYPI which provides
a number of essential services, including but not limited to a Linux
common clock framework provider. Make sure that enable
CONFIG_ARCH_BCM2835 does enable the corresponding mailbox driver.
Signed-off-by: Florian Fainelli <[email protected]>
---
drivers/mailbox/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index 42940108a187..2b4cde562a90 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -109,6 +109,7 @@ config ALTERA_MBOX
config BCM2835_MBOX
tristate "BCM2835 Mailbox"
depends on ARCH_BCM2835
+ default ARCH_BCM2835
help
An implementation of the BCM2385 Mailbox. It is used to invoke
the services of the Videocore. Say Y here if you want to use the
--
2.34.1
On Mon, May 13, 2024 at 04:52:32PM -0700, Florian Fainelli wrote:
> This driver is depended on by CONFIG_FIRMWARE_RASPBERRYPI which provides
> a number of essential services, including but not limited to a Linux
> common clock framework provider. Make sure that enable
> CONFIG_ARCH_BCM2835 does enable the corresponding mailbox driver.
>
> Signed-off-by: Florian Fainelli <[email protected]>
> ---
> drivers/mailbox/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index 42940108a187..2b4cde562a90 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -109,6 +109,7 @@ config ALTERA_MBOX
> config BCM2835_MBOX
> tristate "BCM2835 Mailbox"
> depends on ARCH_BCM2835
> + default ARCH_BCM2835
This is just "default y", since I doubt ARCH_BCM2835 can be a module?
If so, patch 2 could also just be "default y" and I think patch 3 can
have the same logic applied to it, given you're defaulting it to a
dependency also?
Thanks,
Conor.
> help
> An implementation of the BCM2385 Mailbox. It is used to invoke
> the services of the Videocore. Say Y here if you want to use the
> --
> 2.34.1
>
On 5/14/24 05:29, Conor Dooley wrote:
> On Mon, May 13, 2024 at 04:52:32PM -0700, Florian Fainelli wrote:
>> This driver is depended on by CONFIG_FIRMWARE_RASPBERRYPI which provides
>> a number of essential services, including but not limited to a Linux
>> common clock framework provider. Make sure that enable
>> CONFIG_ARCH_BCM2835 does enable the corresponding mailbox driver.
>>
>> Signed-off-by: Florian Fainelli <[email protected]>
>> ---
>> drivers/mailbox/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
>> index 42940108a187..2b4cde562a90 100644
>> --- a/drivers/mailbox/Kconfig
>> +++ b/drivers/mailbox/Kconfig
>> @@ -109,6 +109,7 @@ config ALTERA_MBOX
>> config BCM2835_MBOX
>> tristate "BCM2835 Mailbox"
>> depends on ARCH_BCM2835
>> + default ARCH_BCM2835
>
> This is just "default y", since I doubt ARCH_BCM2835 can be a module?
Right, although I intend to also add COMPILE_TEST, by then, it might be
preferable to have it "default ARCH_BCM2835".
>
> If so, patch 2 could also just be "default y" and I think patch 3 can
> have the same logic applied to it, given you're defaulting it to a
> dependency also?
Right.
--
Florian
Quoting Florian Fainelli (2024-05-13 16:52:34)
> The clock driver is essential in providing clocks for UARTs and other
> peripherals, make it enabled by default.
>
> Signed-off-by: Florian Fainelli <[email protected]>
> ---
Acked-by: Stephen Boyd <[email protected]>
On Tue, May 14, 2024 at 09:20:06AM -0700, Florian Fainelli wrote:
> On 5/14/24 05:29, Conor Dooley wrote:
> > On Mon, May 13, 2024 at 04:52:32PM -0700, Florian Fainelli wrote:
> > > This driver is depended on by CONFIG_FIRMWARE_RASPBERRYPI which provides
> > > a number of essential services, including but not limited to a Linux
> > > common clock framework provider. Make sure that enable
> > > CONFIG_ARCH_BCM2835 does enable the corresponding mailbox driver.
> > >
> > > Signed-off-by: Florian Fainelli <[email protected]>
> > > ---
> > > drivers/mailbox/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> > > index 42940108a187..2b4cde562a90 100644
> > > --- a/drivers/mailbox/Kconfig
> > > +++ b/drivers/mailbox/Kconfig
> > > @@ -109,6 +109,7 @@ config ALTERA_MBOX
> > > config BCM2835_MBOX
> > > tristate "BCM2835 Mailbox"
> > > depends on ARCH_BCM2835
> > > + default ARCH_BCM2835
> >
> > This is just "default y", since I doubt ARCH_BCM2835 can be a module?
>
> Right, although I intend to also add COMPILE_TEST, by then, it might be
> preferable to have it "default ARCH_BCM2835".
I'm not sure what COMPILE_TEST would have to do with the default,
the default shouldn't be important there, right?
On 5/15/24 00:54, Conor Dooley wrote:
> On Tue, May 14, 2024 at 09:20:06AM -0700, Florian Fainelli wrote:
>> On 5/14/24 05:29, Conor Dooley wrote:
>>> On Mon, May 13, 2024 at 04:52:32PM -0700, Florian Fainelli wrote:
>>>> This driver is depended on by CONFIG_FIRMWARE_RASPBERRYPI which provides
>>>> a number of essential services, including but not limited to a Linux
>>>> common clock framework provider. Make sure that enable
>>>> CONFIG_ARCH_BCM2835 does enable the corresponding mailbox driver.
>>>>
>>>> Signed-off-by: Florian Fainelli <[email protected]>
>>>> ---
>>>> drivers/mailbox/Kconfig | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
>>>> index 42940108a187..2b4cde562a90 100644
>>>> --- a/drivers/mailbox/Kconfig
>>>> +++ b/drivers/mailbox/Kconfig
>>>> @@ -109,6 +109,7 @@ config ALTERA_MBOX
>>>> config BCM2835_MBOX
>>>> tristate "BCM2835 Mailbox"
>>>> depends on ARCH_BCM2835
>>>> + default ARCH_BCM2835
>>>
>>> This is just "default y", since I doubt ARCH_BCM2835 can be a module?
>>
>> Right, although I intend to also add COMPILE_TEST, by then, it might be
>> preferable to have it "default ARCH_BCM2835".
>
> I'm not sure what COMPILE_TEST would have to do with the default,
> the default shouldn't be important there, right?
Sorry for the late feedback, what I meant is that when you do enable
COMPILE_TEST, you might not want everything to be defaulted to 'y' by
default, but that can be fixed when I add COMPILE_TEST after this patch
series land.
--
Florian