To: Bjorn Andersson <[email protected]>
To: Konrad Dybcio <[email protected]>
To: Rob Herring <[email protected]>
To: Krzysztof Kozlowski <[email protected]>
To: Conor Dooley <[email protected]>
To: Bartosz Golaszewski <[email protected]>
To: Andrew Halaney <[email protected]>
To: Vinod Koul <[email protected]>
To: David S. Miller <[email protected]>
To: Eric Dumazet <[email protected]>
To: Jakub Kicinski <[email protected]>
To: Paolo Abeni <[email protected]>
To: Bhupesh Sharma <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Changes in v4:
Move "dma-coherent" property within qcom,ethqos.yaml file next to "iommu" property.
- Link to v3: https://lore.kernel.org/r/20240507-mark_ethernet_devices_dma_coherent-v3-0-dbe70d0fa971@quicinc.com
Changes in v3:
Update the schema to specify Ethernet devices as "dma-coherent".
- Link: https://lore.kernel.org/r/20240425-mark_ethernet_devices_dma_coherent-v1-1-ad0755044e26@quicinc.com
Changes in v2:
Remove internal change-id from commit message
- Link to v1: https://lore.kernel.org/r/20240425-mark_ethernet_devices_dma_coherent-v1-1-ad0755044e26@quicinc.com
---
---
Sagar Cheluvegowda (2):
arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent
dt-bindings: net: qcom: ethernet: Allow dma-coherent
Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 2 ++
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++
2 files changed, 4 insertions(+)
---
base-commit: a93289b830ce783955b22fbe5d1274a464c05acf
change-id: 20240425-mark_ethernet_devices_dma_coherent-6c6154b84165
Best regards,
--
Sagar Cheluvegowda <[email protected]>
On SA8775P, Ethernet DMA controller is coherent with the CPU.
allow specifying that.
Signed-off-by: Sagar Cheluvegowda <[email protected]>
---
Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
index 69a337c7e345..6672327358bc 100644
--- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
@@ -61,6 +61,8 @@ properties:
iommus:
maxItems: 1
+ dma-coherent: true
+
phys: true
phy-names:
--
2.34.1
Ethernet devices are cache coherent, mark it as such in the dtsi.
Fixes: ff499a0fbb23 ("arm64: dts: qcom: sa8775p: add the first 1Gb ethernet interface")
Fixes: e952348a7cc7 ("arm64: dts: qcom: sa8775p: add a node for EMAC1")
Signed-off-by: Sagar Cheluvegowda <[email protected]>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 231cea1f0fa8..5ab4ca978837 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -2504,6 +2504,7 @@ ethernet1: ethernet@23000000 {
phy-names = "serdes";
iommus = <&apps_smmu 0x140 0xf>;
+ dma-coherent;
snps,tso;
snps,pbl = <32>;
@@ -2538,6 +2539,7 @@ ethernet0: ethernet@23040000 {
phy-names = "serdes";
iommus = <&apps_smmu 0x120 0xf>;
+ dma-coherent;
snps,tso;
snps,pbl = <32>;
--
2.34.1
On 15/05/2024 02:06, Sagar Cheluvegowda wrote:
> On SA8775P, Ethernet DMA controller is coherent with the CPU.
> allow specifying that.
>
> Signed-off-by: Sagar Cheluvegowda <[email protected]>
> ---
> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
On Tue, 14 May 2024 17:06:50 -0700 you wrote:
> To: Bjorn Andersson <[email protected]>
> To: Konrad Dybcio <[email protected]>
> To: Rob Herring <[email protected]>
> To: Krzysztof Kozlowski <[email protected]>
> To: Conor Dooley <[email protected]>
> To: Bartosz Golaszewski <[email protected]>
> To: Andrew Halaney <[email protected]>
> To: Vinod Koul <[email protected]>
> To: David S. Miller <[email protected]>
> To: Eric Dumazet <[email protected]>
> To: Jakub Kicinski <[email protected]>
> To: Paolo Abeni <[email protected]>
> To: Bhupesh Sharma <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
>
> [...]
Here is the summary with links:
- [v4,1/2] arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent
(no matching commit)
- [v4,2/2] dt-bindings: net: qcom: ethernet: Allow dma-coherent
https://git.kernel.org/netdev/net/c/fe32622763d8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
On Tue, 14 May 2024 17:06:50 -0700, Sagar Cheluvegowda wrote:
> To: Bjorn Andersson <[email protected]>
> To: Konrad Dybcio <[email protected]>
> To: Rob Herring <[email protected]>
> To: Krzysztof Kozlowski <[email protected]>
> To: Conor Dooley <[email protected]>
> To: Bartosz Golaszewski <[email protected]>
> To: Andrew Halaney <[email protected]>
> To: Vinod Koul <[email protected]>
> To: David S. Miller <[email protected]>
> To: Eric Dumazet <[email protected]>
> To: Jakub Kicinski <[email protected]>
> To: Paolo Abeni <[email protected]>
> To: Bhupesh Sharma <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
>
> [...]
Applied, thanks!
[1/2] arm64: dts: qcom: sa8775p: mark ethernet devices as DMA-coherent
commit: 49cc31f8ab44e60d8109da7e18c0983a917d4d74
Best regards,
--
Bjorn Andersson <[email protected]>