2024-05-14 11:35:56

by Wu Bo

Subject: [PATCH] f2fs: initialize last_block_in_bio variable

Initialize last_block_in_bio of struct f2fs_bio_info and clean up code.

Signed-off-by: Wu Bo <[email protected]>
---
fs/f2fs/data.c | 23 +++++++++++++----------
1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index bdbd4195cadc..50ceb25b341d 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -595,17 +595,20 @@ int f2fs_init_write_merge_io(struct f2fs_sb_info *sbi)
return -ENOMEM;

for (j = HOT; j < n; j++) {
- init_f2fs_rwsem(&sbi->write_io[i][j].io_rwsem);
- sbi->write_io[i][j].sbi = sbi;
- sbi->write_io[i][j].bio = NULL;
- spin_lock_init(&sbi->write_io[i][j].io_lock);
- INIT_LIST_HEAD(&sbi->write_io[i][j].io_list);
- INIT_LIST_HEAD(&sbi->write_io[i][j].bio_list);
- init_f2fs_rwsem(&sbi->write_io[i][j].bio_list_lock);
+ struct f2fs_bio_info *io = &sbi->write_io[i][j];
+
+ init_f2fs_rwsem(&io->io_rwsem);
+ io->sbi = sbi;
+ io->bio = NULL;
+ io->last_block_in_bio = 0;
+ spin_lock_init(&io->io_lock);
+ INIT_LIST_HEAD(&io->io_list);
+ INIT_LIST_HEAD(&io->bio_list);
+ init_f2fs_rwsem(&io->bio_list_lock);
#ifdef CONFIG_BLK_DEV_ZONED
- init_completion(&sbi->write_io[i][j].zone_wait);
- sbi->write_io[i][j].zone_pending_bio = NULL;
- sbi->write_io[i][j].bi_private = NULL;
+ init_completion(&io->zone_wait);
+ io->zone_pending_bio = NULL;
+ io->bi_private = NULL;
#endif
}
}
--
2.25.1

2024-05-15 01:58:38

by Chao Yu

Subject: Re: [PATCH] f2fs: initialize last_block_in_bio variable

On 2024/5/14 19:35, Wu Bo wrote:
> Initialize last_block_in_bio of struct f2fs_bio_info and clean up code.
>
> Signed-off-by: Wu Bo <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2024-05-15 04:20:41

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH] f2fs: initialize last_block_in_bio variable

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Tue, 14 May 2024 05:35:29 -0600 you wrote:
> Initialize last_block_in_bio of struct f2fs_bio_info and clean up code.
>
> Signed-off-by: Wu Bo <[email protected]>
> ---
> fs/f2fs/data.c | 23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)

Here is the summary with links:
- [f2fs-dev] f2fs: initialize last_block_in_bio variable
https://git.kernel.org/jaegeuk/f2fs/c/16409fdbb882

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html