2024-05-14 18:01:34

by Unnathi Chalicheemala

Subject: [PATCH] firmware: qcom-scm: Remove QCOM_SMC_WAITQ_FLAG_WAKE_ALL

This flag was never supported by firmware, so remove it.

Signed-off-by: Unnathi Chalicheemala <[email protected]>
---
drivers/firmware/qcom/qcom_scm.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
index 68f4df7e6c3c..d511ede6f172 100644
--- a/drivers/firmware/qcom/qcom_scm.c
+++ b/drivers/firmware/qcom/qcom_scm.c
@@ -114,7 +114,6 @@ static const u8 qcom_scm_cpu_warm_bits[QCOM_SCM_BOOT_MAX_CPUS] = {
};

#define QCOM_SMC_WAITQ_FLAG_WAKE_ONE BIT(0)
-#define QCOM_SMC_WAITQ_FLAG_WAKE_ALL BIT(1)

#define QCOM_DLOAD_MASK GENMASK(5, 4)
#define QCOM_DLOAD_NODUMP 0
@@ -1793,9 +1792,8 @@ static irqreturn_t qcom_scm_irq_handler(int irq, void *data)
goto out;
}

- if (flags != QCOM_SMC_WAITQ_FLAG_WAKE_ONE &&
- flags != QCOM_SMC_WAITQ_FLAG_WAKE_ALL) {
- dev_err(scm->dev, "Invalid flags found for wq_ctx: %u\n", flags);
+ if (flags != QCOM_SMC_WAITQ_FLAG_WAKE_ONE) {
+ dev_err(scm->dev, "Invalid flags received for wq_ctx: %u\n", flags);
goto out;
}

--
2.34.1

2024-05-15 22:08:45

by Elliot Berman

Subject: Re: [PATCH] firmware: qcom-scm: Remove QCOM_SMC_WAITQ_FLAG_WAKE_ALL

On Tue, May 14, 2024 at 11:00:46AM -0700, Unnathi Chalicheemala wrote:
> This flag was never supported by firmware, so remove it.
>
> Signed-off-by: Unnathi Chalicheemala <[email protected]>

Reviewed-by: Elliot Berman <[email protected]>

> ---
> drivers/firmware/qcom/qcom_scm.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
> index 68f4df7e6c3c..d511ede6f172 100644
> --- a/drivers/firmware/qcom/qcom_scm.c
> +++ b/drivers/firmware/qcom/qcom_scm.c
> @@ -114,7 +114,6 @@ static const u8 qcom_scm_cpu_warm_bits[QCOM_SCM_BOOT_MAX_CPUS] = {
> };
>
> #define QCOM_SMC_WAITQ_FLAG_WAKE_ONE BIT(0)
> -#define QCOM_SMC_WAITQ_FLAG_WAKE_ALL BIT(1)
>
> #define QCOM_DLOAD_MASK GENMASK(5, 4)
> #define QCOM_DLOAD_NODUMP 0
> @@ -1793,9 +1792,8 @@ static irqreturn_t qcom_scm_irq_handler(int irq, void *data)
> goto out;
> }
>
> - if (flags != QCOM_SMC_WAITQ_FLAG_WAKE_ONE &&
> - flags != QCOM_SMC_WAITQ_FLAG_WAKE_ALL) {
> - dev_err(scm->dev, "Invalid flags found for wq_ctx: %u\n", flags);
> + if (flags != QCOM_SMC_WAITQ_FLAG_WAKE_ONE) {
> + dev_err(scm->dev, "Invalid flags received for wq_ctx: %u\n", flags);
> goto out;
> }
>
> --
> 2.34.1
>

2024-05-28 03:42:04

by Bjorn Andersson

Subject: Re: [PATCH] firmware: qcom-scm: Remove QCOM_SMC_WAITQ_FLAG_WAKE_ALL

On Tue, 14 May 2024 11:00:46 -0700, Unnathi Chalicheemala wrote:
> This flag was never supported by firmware, so remove it.
>
>

Applied, thanks!

[1/1] firmware: qcom-scm: Remove QCOM_SMC_WAITQ_FLAG_WAKE_ALL
commit: f63f815fc2a5ca9d57beba0286aaa82bc3277353

Best regards,
--
Bjorn Andersson <[email protected]>