2024-05-15 15:08:19

by Borislav Petkov

Subject: [PATCH] KVM: Unexport kvm_debugfs_dir

From: "Borislav Petkov (AMD)" <[email protected]>

After

faf01aef0570 ("KVM: PPC: Merge powerpc's debugfs entry content into generic entry")

kvm_debugfs_dir is not used anywhere else outside of kvm_main.c

Unexport it and make it static.

Signed-off-by: Borislav Petkov (AMD) <[email protected]>
---
include/linux/kvm_host.h | 2 --
virt/kvm/kvm_main.c | 3 +--
2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 48f31dcd318a..c8bc33aab26a 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -1959,8 +1959,6 @@ struct _kvm_stats_desc {
HALT_POLL_HIST_COUNT), \
STATS_DESC_IBOOLEAN(VCPU_GENERIC, blocking)

-extern struct dentry *kvm_debugfs_dir;
-
ssize_t kvm_stats_read(char *id, const struct kvm_stats_header *header,
const struct _kvm_stats_desc *desc,
void *stats, size_t size_stats,
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index ff0a20565f90..382e2ab14137 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -110,8 +110,7 @@ static struct kmem_cache *kvm_vcpu_cache;
static __read_mostly struct preempt_ops kvm_preempt_ops;
static DEFINE_PER_CPU(struct kvm_vcpu *, kvm_running_vcpu);

-struct dentry *kvm_debugfs_dir;
-EXPORT_SYMBOL_GPL(kvm_debugfs_dir);
+static struct dentry *kvm_debugfs_dir;

static const struct file_operations stat_fops_per_vm;

--
2.43.0

2024-06-04 23:30:48

by Sean Christopherson

Subject: Re: [PATCH] KVM: Unexport kvm_debugfs_dir

On Wed, 15 May 2024 17:08:04 +0200, Borislav Petkov wrote:
> After
>
> faf01aef0570 ("KVM: PPC: Merge powerpc's debugfs entry content into generic entry")
>
> kvm_debugfs_dir is not used anywhere else outside of kvm_main.c
>
> Unexport it and make it static.
>
> [...]

Applied to kvm-x86 generic, thanks!

[1/1] KVM: Unexport kvm_debugfs_dir
https://github.com/kvm-x86/linux/commit/96a02b9fa951

--
https://github.com/kvm-x86/linux/tree/next