2024-05-16 02:57:26

by Mao Jinlong

Subject: [PATCH v1 1/3] dt-bindings: arm: Add trace-id for coresight dummy source

Add trace-id for static id support to coresight dummy source.

Signed-off-by: Mao Jinlong <[email protected]>
---
.../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
index 6745b4cc8f1c..9adf34ea450e 100644
--- a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
+++ b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
@@ -38,6 +38,12 @@ properties:
enum:
- arm,coresight-dummy-source

+ trace-id:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ If dummy source needs static id support, use this to set trace id.
+ The range is 1 to 127.
+
out-ports:
$ref: /schemas/graph.yaml#/properties/ports

--
2.41.0

2024-05-16 13:51:24

by James Clark

Subject: Re: [PATCH v1 1/3] dt-bindings: arm: Add trace-id for coresight dummy source

On 16/05/2024 04:56, Mao Jinlong wrote:
> Add trace-id for static id support to coresight dummy source.
>
> Signed-off-by: Mao Jinlong <[email protected]>
> ---
> .../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
> index 6745b4cc8f1c..9adf34ea450e 100644
> --- a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
> @@ -38,6 +38,12 @@ properties:
> enum:
> - arm,coresight-dummy-source
>
> + trace-id:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + If dummy source needs static id support, use this to set trace id.
> + The range is 1 to 127.
> +

The max is CORESIGHT_TRACE_ID_RES_TOP, so this would be 1 to 111 (inclusive)

> out-ports:
> $ref: /schemas/graph.yaml#/properties/ports
>

2024-05-19 17:47:41

by Krzysztof Kozlowski

Subject: Re: [PATCH v1 1/3] dt-bindings: arm: Add trace-id for coresight dummy source

On 16/05/2024 04:56, Mao Jinlong wrote:
> Add trace-id for static id support to coresight dummy source.
>
> Signed-off-by: Mao Jinlong <[email protected]>
> ---
> .../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
> index 6745b4cc8f1c..9adf34ea450e 100644
> --- a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
> +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml
> @@ -38,6 +38,12 @@ properties:
> enum:
> - arm,coresight-dummy-source
>
> + trace-id:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + If dummy source needs static id support, use this to set trace id.
> + The range is 1 to 127.

Missing constraints... and then no need to repeat constraints in free
form text.

Best regards,
Krzysztof