2024-05-14 11:48:01

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 4.19 00/63] 4.19.314-rc1 review

This is the start of the stable review cycle for the 4.19.314 release.
There are 63 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Thu, 16 May 2024 10:09:32 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.314-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 4.19.314-rc1

Kuniyuki Iwashima <[email protected]>
af_unix: Suppress false-positive lockdep splat for spin_lock() in __unix_gc().

Thadeu Lima de Souza Cascardo <[email protected]>
net: fix out-of-bounds access in ops_init

Zack Rusin <[email protected]>
drm/vmwgfx: Fix invalid reads in fence signaled events

Jim Cromie <[email protected]>
dyndbg: fix old BUG_ON in >control parser

Paolo Abeni <[email protected]>
tipc: fix UAF in error path

Chris Wulff <[email protected]>
usb: gadget: f_fs: Fix a race condition when processing setup packets.

Peter Korsgaard <[email protected]>
usb: gadget: composite: fix OS descriptors w_value logic

Thanassis Avgerinos <[email protected]>
firewire: nosy: ensure user_length is taken into account when fetching packet contents

Michal Luczaj <[email protected]>
af_unix: Fix garbage collector racing against connect()

Kuniyuki Iwashima <[email protected]>
af_unix: Do not use atomic ops for unix_sk(sk)->inflight.

Eric Dumazet <[email protected]>
ipv6: fib6_rules: avoid possible NULL dereference in fib6_rule_action()

Felix Fietkau <[email protected]>
net: bridge: fix corrupted ethernet header on multicast-to-unicast

Eric Dumazet <[email protected]>
phonet: fix rtm_phonet_notify() skb allocation

Roded Zats <[email protected]>
rtnetlink: Correct nested IFLA_VF_VLAN_LIST attribute validation

Duoming Zhou <[email protected]>
Bluetooth: l2cap: fix null-ptr-deref in l2cap_chan_timeout

Duoming Zhou <[email protected]>
Bluetooth: Fix use-after-free bugs caused by sco_sock_timeout

Kuniyuki Iwashima <[email protected]>
tcp: Use refcount_inc_not_zero() in tcp_twsk_unique().

Eric Dumazet <[email protected]>
tcp: defer shutdown(SEND_SHUTDOWN) for TCP_SYN_RECV sockets

Colin Ian King <[email protected]>
tcp: remove redundant check on tskb

Neil Armstrong <[email protected]>
ASoC: meson: axg-tdm-interface: Fix formatters in trigger"

Vanillan Wang <[email protected]>
net:usb:qmi_wwan: support Rolling modules

Joakim Sindholt <[email protected]>
fs/9p: drop inodes immediately on non-.L too

Andy Shevchenko <[email protected]>
gpio: crystalcove: Use -ENOTSUPP consistently

Andy Shevchenko <[email protected]>
gpio: wcove: Use -ENOTSUPP consistently

Jeff Layton <[email protected]>
9p: explicitly deny setlease attempts

Joakim Sindholt <[email protected]>
fs/9p: translate O_TRUNC into OTRUNC

Joakim Sindholt <[email protected]>
fs/9p: only translate RWX permissions for plain 9P2000

John Stultz <[email protected]>
selftests: timers: Fix valid-adjtimex signed left-shift undefined behavior

Maurizio Lombardi <[email protected]>
scsi: target: Fix SELinux error when systemd-modules loads the target module

Boris Burkov <[email protected]>
btrfs: always clear PERTRANS metadata during commit

Boris Burkov <[email protected]>
btrfs: make btrfs_clear_delalloc_extent() free delalloc reserve

Peng Liu <[email protected]>
tools/power turbostat: Fix Bzy_MHz documentation typo

Doug Smythies <[email protected]>
tools/power turbostat: Fix added raw MSR output

Adam Goldman <[email protected]>
firewire: ohci: mask bus reset interrupts between ISR and bottom half

Chen Ni <[email protected]>
ata: sata_gemini: Check clk_enable() result

Phil Elwell <[email protected]>
net: bcmgenet: Reset RBUF on first open

Takashi Iwai <[email protected]>
ALSA: line6: Zero-initialize message buffers

Saurav Kashyap <[email protected]>
scsi: bnx2fc: Remove spin_lock_bh while releasing resources after upload

linke li <[email protected]>
net: mark racy access on sk->sk_rcvbuf

Jeff Johnson <[email protected]>
wifi: mac80211: fix ieee80211_bss_*_flags kernel-doc

Andrew Price <[email protected]>
gfs2: Fix invalid metadata access in punch_hole

Justin Tee <[email protected]>
scsi: lpfc: Update lpfc_ramp_down_queue_handler() logic

Xin Long <[email protected]>
tipc: fix a possible memleak in tipc_buf_append

Felix Fietkau <[email protected]>
net: bridge: fix multicast-to-unicast with fraglist GSO

Marek Behún <[email protected]>
net: dsa: mv88e6xxx: Fix number of databases for 88E6141 / 88E6341

Andrew Lunn <[email protected]>
net: dsa: mv88e6xxx: Add number of MACs in the ATU

Jerome Brunet <[email protected]>
ASoC: meson: axg-tdm-interface: manage formatters in trigger

David Bauer <[email protected]>
net l2tp: drop flow hash on forward

Kuniyuki Iwashima <[email protected]>
nsh: Restore skb->{protocol,data,mac_header} for outer header in nsh_gso_segment().

Bui Quang Minh <[email protected]>
bna: ensure the copied buf is NUL terminated

Claudio Imbrenda <[email protected]>
s390/mm: Fix clearing storage keys for huge pages

Claudio Imbrenda <[email protected]>
s390/mm: Fix storage key clearing for guest huge pages

Zeng Heng <[email protected]>
pinctrl: devicetree: fix refcount leak in pinctrl_dt_to_map()

Arnd Bergmann <[email protected]>
power: rt9455: hide unused rt9455_boost_voltage_values

Dan Carpenter <[email protected]>
pinctrl: core: delete incorrect free in pinctrl_enable()

Rahul Rameshbabu <[email protected]>
ethernet: Add helper for assigning packet type when dest address does not match device address

Jakub Kicinski <[email protected]>
ethernet: add a helper for assigning port addresses

Li RongQing <[email protected]>
net: slightly optimize eth_type_trans

Mukul Joshi <[email protected]>
drm/amdgpu: Fix leak when GPU memory allocation fails

Eric Huang <[email protected]>
drm/amdkfd: change system memory overcommit limit

Johannes Berg <[email protected]>
wifi: nl80211: don't free NULL coalescing rule

Vinod Koul <[email protected]>
dmaengine: Revert "dmaengine: pl330: issue_pending waits until WFP state"

Bumyong Lee <[email protected]>
dmaengine: pl330: issue_pending waits until WFP state


-------------

Diffstat:

Makefile | 4 +-
arch/s390/mm/gmap.c | 2 +-
arch/s390/mm/hugetlbpage.c | 2 +-
drivers/ata/sata_gemini.c | 5 +-
drivers/firewire/nosy.c | 6 +-
drivers/firewire/ohci.c | 6 +-
drivers/gpio/gpio-crystalcove.c | 2 +-
drivers/gpio/gpio-wcove.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 100 +++++++++++++----------
drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +-
drivers/net/dsa/mv88e6xxx/chip.c | 29 ++++++-
drivers/net/dsa/mv88e6xxx/chip.h | 6 ++
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 16 +++-
drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 4 +-
drivers/net/usb/qmi_wwan.c | 1 +
drivers/pinctrl/core.c | 8 +-
drivers/pinctrl/devicetree.c | 10 ++-
drivers/power/supply/rt9455_charger.c | 2 +
drivers/scsi/bnx2fc/bnx2fc_tgt.c | 2 -
drivers/scsi/lpfc/lpfc.h | 1 -
drivers/scsi/lpfc/lpfc_scsi.c | 13 +--
drivers/target/target_core_configfs.c | 12 +++
drivers/usb/gadget/composite.c | 6 +-
drivers/usb/gadget/function/f_fs.c | 2 +-
fs/9p/vfs_file.c | 2 +
fs/9p/vfs_inode.c | 5 +-
fs/9p/vfs_super.c | 1 +
fs/btrfs/inode.c | 2 +-
fs/btrfs/transaction.c | 2 +-
fs/gfs2/bmap.c | 5 +-
include/linux/etherdevice.h | 46 +++++++++++
include/net/af_unix.h | 5 +-
lib/dynamic_debug.c | 6 +-
net/bluetooth/l2cap_core.c | 3 +
net/bluetooth/sco.c | 4 +
net/bridge/br_forward.c | 9 +-
net/core/net_namespace.c | 13 ++-
net/core/rtnetlink.c | 2 +-
net/core/sock.c | 4 +-
net/ethernet/eth.c | 10 +--
net/ipv4/tcp.c | 4 +-
net/ipv4/tcp_input.c | 2 +
net/ipv4/tcp_ipv4.c | 8 +-
net/ipv4/tcp_output.c | 11 ++-
net/ipv6/fib6_rules.c | 6 +-
net/l2tp/l2tp_eth.c | 3 +
net/mac80211/ieee80211_i.h | 4 +-
net/nsh/nsh.c | 14 ++--
net/phonet/pn_netlink.c | 2 +-
net/tipc/msg.c | 8 +-
net/unix/af_unix.c | 4 +-
net/unix/garbage.c | 35 +++++---
net/unix/scm.c | 8 +-
net/wireless/nl80211.c | 2 +
sound/usb/line6/driver.c | 6 +-
tools/power/x86/turbostat/turbostat.8 | 2 +-
tools/power/x86/turbostat/turbostat.c | 7 +-
tools/testing/selftests/timers/valid-adjtimex.c | 73 ++++++++---------
58 files changed, 370 insertions(+), 191 deletions(-)




2024-05-14 11:49:04

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 4.19 61/63] drm/vmwgfx: Fix invalid reads in fence signaled events

4.19-stable review patch. If anyone has any objections, please let me know.

------------------

From: Zack Rusin <[email protected]>

commit a37ef7613c00f2d72c8fc08bd83fb6cc76926c8c upstream.

Correctly set the length of the drm_event to the size of the structure
that's actually used.

The length of the drm_event was set to the parent structure instead of
to the drm_vmw_event_fence which is supposed to be read. drm_read
uses the length parameter to copy the event to the user space thus
resuling in oob reads.

Signed-off-by: Zack Rusin <[email protected]>
Fixes: 8b7de6aa8468 ("vmwgfx: Rework fence event action")
Reported-by: [email protected] # ZDI-CAN-23566
Cc: David Airlie <[email protected]>
CC: Daniel Vetter <[email protected]>
Cc: Zack Rusin <[email protected]>
Cc: Broadcom internal kernel review list <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: <[email protected]> # v3.4+
Reviewed-by: Maaz Mombasawala <[email protected]>
Reviewed-by: Martin Krastev <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
@@ -1064,7 +1064,7 @@ static int vmw_event_fence_action_create
}

event->event.base.type = DRM_VMW_EVENT_FENCE_SIGNALED;
- event->event.base.length = sizeof(*event);
+ event->event.base.length = sizeof(event->event);
event->event.user_data = user_data;

ret = drm_event_reserve_init(dev, file_priv, &event->base, &event->event.base);



2024-05-14 16:34:36

by Harshit Mogalapalli

[permalink] [raw]
Subject: Re: [PATCH 4.19 00/63] 4.19.314-rc1 review

Hi Greg,


On 14/05/24 15:49, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.314 release.
> There are 63 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 16 May 2024 10:09:32 +0000.
> Anything received after that time might be too late.
>


No problems seen on x86_64 and aarch64 with our testing.

Tested-by: Harshit Mogalapalli <[email protected]>


Thanks,
Harshit
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.314-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

2024-05-14 19:42:10

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 4.19 00/63] 4.19.314-rc1 review

Hi1

> This is the start of the stable review cycle for the 4.19.314 release.
> There are 63 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y

Tested-by: Pavel Machek (CIP) <[email protected]>

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Attachments:
(No filename) (661.00 B)
signature.asc (201.00 B)
Download all attachments

2024-05-15 15:05:35

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 4.19 00/63] 4.19.314-rc1 review

On 5/14/24 04:19, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.314 release.
> There are 63 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 16 May 2024 10:09:32 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.314-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

Compiled and booted on my test system. No dmesg regressions.

Tested-by: Shuah Khan <[email protected]>

thanks,
-- Shuah

2024-05-16 07:33:58

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH 4.19 00/63] 4.19.314-rc1 review

On Tue, 14 May 2024 at 13:39, Greg Kroah-Hartman
<[email protected]> wrote:
>
> This is the start of the stable review cycle for the 4.19.314 release.
> There are 63 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 16 May 2024 10:09:32 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.314-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Results from Linaro’s test farm.
No regressions on arm64, arm, x86_64, and i386.

Tested-by: Linux Kernel Functional Testing <[email protected]>

## Build
* kernel: 4.19.314-rc1
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-4.19.y
* git commit: 61b47a187ce8efaf5f5b7cd7e2ab6ca1b7da2557
* git describe: v4.19.313-62-g61b47a187ce8
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-4.19.y/build/v4.19313-62-g61b47a187ce8/

## Test Regressions (compared to v4.19.313)

## Metric Regressions (compared to v4.19.313)

## Test Fixes (compared to v4.19.313)

## Metric Fixes (compared to v4.19.313)

## Test result summary
total: 42289, pass: 38159, fail: 195, skip: 3906, xfail: 29

## Build Summary
* arc: 10 total, 10 passed, 0 failed
* arm: 102 total, 96 passed, 6 failed
* arm64: 28 total, 23 passed, 5 failed
* i386: 15 total, 12 passed, 3 failed
* mips: 19 total, 19 passed, 0 failed
* parisc: 3 total, 0 passed, 3 failed
* powerpc: 24 total, 24 passed, 0 failed
* s390: 6 total, 6 passed, 0 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 6 total, 6 passed, 0 failed
* x86_64: 24 total, 19 passed, 5 failed

## Test suites summary
* boot
* kselftest-android
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-drivers-dma-buf
* kselftest-efivarfs
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-filesystems-epoll
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kexec
* kselftest-lib
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mm
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-net-forwarding
* kselftest-net-mptcp
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-rseq
* kselftest-rtc
* kselftest-seccomp
* kselftest-sigaltstack
* kselftest-size
* kselftest-splice
* kselftest-static_keys
* kselftest-sync
* kselftest-sysctl
* kselftest-tc-testing
* kselftest-timens
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-user_events
* kselftest-vDSO
* kselftest-watchdog
* kselftest-zram
* kunit
* log-parser-boot
* log-parser-test
* ltp-cap_bounds
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-hugetlb
* ltp-io
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-securebits
* ltp-smoke
* ltp-smoketest
* ltp-syscalls
* ltp-tracing
* rcutorture

--
Linaro LKFT
https://lkft.linaro.org

2024-05-16 12:29:08

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 4.19 00/63] 4.19.314-rc1 review

Hi!

> This is the start of the stable review cycle for the 4.19.314 release.
> There are 63 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.

> Rahul Rameshbabu <[email protected]>
> ethernet: Add helper for assigning packet type when dest address
> does not match device address

So this went in, and has 2 below patches as a dependencies, but it is
just a cleanup we should not really need it... or the other 2 patches.

> Jakub Kicinski <[email protected]>
> ethernet: add a helper for assigning port addresses
> Li RongQing <[email protected]>
> net: slightly optimize eth_type_trans

> Vinod Koul <[email protected]>
> dmaengine: Revert "dmaengine: pl330: issue_pending waits until WFP state"
> Bumyong Lee <[email protected]>
> dmaengine: pl330: issue_pending waits until WFP state

We apply patch just to revert it immediately. Rules say "- It must be
obviously correct and tested.". You do this often, should the rules be
fixed?

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Attachments:
(No filename) (1.25 kB)
signature.asc (201.00 B)
Download all attachments

2024-05-16 12:30:36

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH 4.19 00/63] 4.19.314-rc1 review

On Tue, 14 May 2024 12:19:21 +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.19.314 release.
> There are 63 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 16 May 2024 10:09:32 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.314-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

All tests passing for Tegra ...

Test results for stable-v4.19:
10 builds: 10 pass, 0 fail
20 boots: 20 pass, 0 fail
37 tests: 37 pass, 0 fail

Linux version: 4.19.314-rc1-g61b47a187ce8
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04

Tested-by: Jon Hunter <[email protected]>

Jon

2024-05-16 13:10:08

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 4.19 00/63] 4.19.314-rc1 review

On Thu, May 16, 2024 at 02:24:02PM +0200, Pavel Machek wrote:
> > Vinod Koul <[email protected]>
> > dmaengine: Revert "dmaengine: pl330: issue_pending waits until WFP state"
> > Bumyong Lee <[email protected]>
> > dmaengine: pl330: issue_pending waits until WFP state
>
> We apply patch just to revert it immediately. Rules say "- It must be
> obviously correct and tested.". You do this often, should the rules be
> fixed?

We apply patches that are cc: stable and having the change, and then the
revert, is the best way forward otherwise we get lots of complaints we
didn't take the first commit. This way all tools are happy, and people
are not confused as to why we did not take patches we should have.

greg k-h