2024-05-06 20:22:04

by Andy Shevchenko

[permalink] [raw]
Subject: [PATCH v4 0/5] PCI: controller: Move to agnostic GPIO API

While at it, remove of_gpio.h leftover from some of the drivers.

In v4:
- added tag (Mani)
- fixed a polarity bug in iMX.6 driver (Linus)

In v3:
- added precursor patch 1 to avoid build errors (LKP)
- used GPIOD_OUT_LOW instead of GPIOD_ASIS (Mani)
- added tags (Mani, Frank)

In v2:
- combined previously sent patches into a series (Manivannan)
- added tags (Rob, Manivannan)
- converted iMX.6 driver (Manivannan)
- dropped leftover in aadvark drivers (Manivannan)

Andy Shevchenko (5):
PCI: dra7xx: Add missing header inclusion
PCI: aardvark: Remove unused of_gpio.h
PCI: dwc: Remove unused of_gpio.h
PCI: imx6: Convert to agnostic GPIO API
PCI: kirin: Convert to agnostic GPIO API

drivers/pci/controller/dwc/pci-dra7xx.c | 2 +-
drivers/pci/controller/dwc/pci-imx6.c | 36 ++-----
drivers/pci/controller/dwc/pci-meson.c | 1 -
drivers/pci/controller/dwc/pcie-kirin.c | 105 +++++++--------------
drivers/pci/controller/dwc/pcie-qcom.c | 1 -
drivers/pci/controller/dwc/pcie-tegra194.c | 2 -
drivers/pci/controller/pci-aardvark.c | 1 -
7 files changed, 46 insertions(+), 102 deletions(-)

--
2.43.0.rc1.1336.g36b5255a03ac



2024-05-07 10:19:08

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v4 0/5] PCI: controller: Move to agnostic GPIO API

On Mon, May 6, 2024 at 4:22 PM Andy Shevchenko
<[email protected]> wrote:

> In v4:
> - added tag (Mani)
> - fixed a polarity bug in iMX.6 driver (Linus)

Looks good now. The series:
Reviewed-by: Linus Walleij <[email protected]>

Perhaps the use of _raw accessors could be avoided in 5/5 by some
elaborart polarity quirk but I'm no perfectionist and it can be fixed later.

Yours,
Linus Walleij

2024-05-07 13:13:35

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v4 0/5] PCI: controller: Move to agnostic GPIO API

On Tue, May 07, 2024 at 12:03:50PM +0200, Linus Walleij wrote:
> On Mon, May 6, 2024 at 4:22 PM Andy Shevchenko
> <[email protected]> wrote:
>
> > In v4:
> > - added tag (Mani)
> > - fixed a polarity bug in iMX.6 driver (Linus)
>
> Looks good now. The series:
> Reviewed-by: Linus Walleij <[email protected]>

Thank you!

> Perhaps the use of _raw accessors could be avoided in 5/5 by some
> elaborart polarity quirk but I'm no perfectionist and it can be fixed later.

After your comment I was thinking the same, and came to the similar conclusion,
we might fix this later as in comparison to iMX.6 case this requires an
additional code to be added to gpiolib-of.c.

--
With Best Regards,
Andy Shevchenko



2024-05-17 10:22:48

by Krzysztof Wilczyński

[permalink] [raw]
Subject: Re: [PATCH v4 0/5] PCI: controller: Move to agnostic GPIO API

Hello,

> While at it, remove of_gpio.h leftover from some of the drivers.

Applied to gpio, thank you!

[01/05] PCI: dra7xx: Add missing chained IRQ header inclusion
https://git.kernel.org/pci/pci/c/1d1efd131cc1
[02/05] PCI: aardvark: Remove unused of_gpio.h inclusion
https://git.kernel.org/pci/pci/c/83bf80dc8e2f
[03/05] PCI: dwc: Remove unused of_gpio.h inclusion
https://git.kernel.org/pci/pci/c/8f69a807234b
[04/05] PCI: imx6: Convert to use agnostic GPIO API
https://git.kernel.org/pci/pci/c/7dfa559abc93
[05/05] PCI: kirin: Convert to use agnostic GPIO API
https://git.kernel.org/pci/pci/c/7ca698ff686c

Krzysztof

2024-05-17 19:32:20

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v4 0/5] PCI: controller: Move to agnostic GPIO API

On Fri, May 17, 2024 at 07:22:34PM +0900, Krzysztof Wilczyński wrote:
> Hello,
>
> > While at it, remove of_gpio.h leftover from some of the drivers.
>
> Applied to gpio, thank you!

Thank you!

--
With Best Regards,
Andy Shevchenko