2024-04-01 10:01:13

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] dt-bindings: PCI: rockchip,rk3399-pcie: add missing maxItems to ep-gpios

Properties with GPIOs should define number of actual GPIOs, so add
missing maxItems to ep-gpios. Otherwise multiple GPIOs could be
provided which is not a true hardware description.

Fixes: aa222f9311e1 ("dt-bindings: PCI: Convert Rockchip RK3399 PCIe to DT schema")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml
index 531008f0b6ac..002b728cbc71 100644
--- a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml
@@ -37,6 +37,7 @@ properties:
description: This property is needed if using 24MHz OSC for RC's PHY.

ep-gpios:
+ maxItems: 1
description: pre-reset GPIO

vpcie12v-supply:
--
2.34.1



2024-04-01 10:47:29

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: PCI: rockchip,rk3399-pcie: add missing maxItems to ep-gpios

On Mon, Apr 01, 2024 at 12:00:58PM +0200, Krzysztof Kozlowski wrote:
> Properties with GPIOs should define number of actual GPIOs, so add
> missing maxItems to ep-gpios. Otherwise multiple GPIOs could be
> provided which is not a true hardware description.
>
> Fixes: aa222f9311e1 ("dt-bindings: PCI: Convert Rockchip RK3399 PCIe to DT schema")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Thanks,
Conor.

Attachments:
(No filename) (498.00 B)
 signature.asc (235.00 B)
 Download all attachments

2024-04-09 14:10:30

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: PCI: rockchip,rk3399-pcie: add missing maxItems to ep-gpios


On Mon, 01 Apr 2024 12:00:58 +0200, Krzysztof Kozlowski wrote:
> Properties with GPIOs should define number of actual GPIOs, so add
> missing maxItems to ep-gpios. Otherwise multiple GPIOs could be
> provided which is not a true hardware description.
>
> Fixes: aa222f9311e1 ("dt-bindings: PCI: Convert Rockchip RK3399 PCIe to DT schema")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml | 1 +
> 1 file changed, 1 insertion(+)
>

Applied, thanks!


2024-05-17 10:24:30

by Krzysztof Wilczyński

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: PCI: rockchip,rk3399-pcie: add missing maxItems to ep-gpios

Hello,

> Properties with GPIOs should define number of actual GPIOs, so add
> missing maxItems to ep-gpios. Otherwise multiple GPIOs could be
> provided which is not a true hardware description.

Applied to dt-bindings, thank you!

[1/1] dt-bindings: PCI: rockchip,rk3399-pcie: Add missing maxItems to ep-gpios
https://git.kernel.org/pci/pci/c/52d06636a4ae

Krzysztof