2024-04-05 18:18:47

by Christophe JAILLET

Subject: [PATCH] PCI: endpoint: Remove some unused fields in struct pci_epf_group

In "struct pci_epf_group", the 'type_group' field is unused.

This was added, but already unused, by commit 70b3740f2c19 ("PCI: endpoint:
Automatically create a function specific attributes group")

Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only.
---
drivers/pci/endpoint/pci-ep-cfs.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c
index 0ea64e24ed61..ad4e2e329ae9 100644
--- a/drivers/pci/endpoint/pci-ep-cfs.c
+++ b/drivers/pci/endpoint/pci-ep-cfs.c
@@ -23,7 +23,6 @@ struct pci_epf_group {
struct config_group group;
struct config_group primary_epc_group;
struct config_group secondary_epc_group;
- struct config_group *type_group;
struct delayed_work cfs_work;
struct pci_epf *epf;
int index;
--
2.44.0

2024-05-17 11:09:11

by Krzysztof Wilczyński

Subject: Re: [PATCH] PCI: endpoint: Remove some unused fields in struct pci_epf_group

Hello,

> In "struct pci_epf_group", the 'type_group' field is unused.
>
> This was added, but already unused, by commit 70b3740f2c19 ("PCI: endpoint:
> Automatically create a function specific attributes group")
>
> Remove it.
>
> Found with cppcheck, unusedStructMember.

Applied to endpoint, thank you!

[1/1] PCI: endpoint: Remove unused field in struct pci_epf_group
https://git.kernel.org/pci/pci/c/ddc66cc4e695

Krzysztof