2024-05-02 02:14:20

by Jakub Kicinski

Subject: Re: [PATCH net-next v12 13/13] netlink: specs: tsinfo: Enhance netlink attributes and add a set command

On Tue, 30 Apr 2024 17:49:56 +0200 Kory Maincent wrote:
> + -
> + name: hwtst-provider
> + type: nest
> + nested-attributes: tsinfo-hwtst-provider
> + -
> + name: hwtst-flags
> + type: u32

C code is unhappy about the naming here vs what the actual C enums
are called (make -C tools/net/ynl)

You can keep the shorter names if very strongly prefer (????‍↔️) but then
you need to give C code gen hints about naming:
https://docs.kernel.org/next/userspace-api/netlink/c-code-gen.html

2024-05-17 15:58:52

by Kory Maincent

Subject: Re: [PATCH net-next v12 13/13] netlink: specs: tsinfo: Enhance netlink attributes and add a set command

On Wed, 1 May 2024 19:14:07 -0700
Jakub Kicinski <[email protected]> wrote:

> On Tue, 30 Apr 2024 17:49:56 +0200 Kory Maincent wrote:
> > + -
> > + name: hwtst-provider
> > + type: nest
> > + nested-attributes: tsinfo-hwtst-provider
> > + -
> > + name: hwtst-flags
> > + type: u32
>
> C code is unhappy about the naming here vs what the actual C enums
> are called (make -C tools/net/ynl)

Thanks I didn't know that check.
It allows me to fix several name issue!

Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com