2024-05-17 23:40:41

by Dr. David Alan Gilbert

Subject: [PATCH v3] dmaengine: qcom: gpi: remove unused struct 'reg_info'

From: "Dr. David Alan Gilbert" <[email protected]>

'reg_info' was never used since it's initial
commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver")
Remove it.

Signed-off-by: Dr. David Alan Gilbert <[email protected]>
Reviewed-by: Bryan O'Donoghue <[email protected]>
---
drivers/dma/qcom/gpi.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
index 1c93864e0e4d..639ab304db9b 100644
--- a/drivers/dma/qcom/gpi.c
+++ b/drivers/dma/qcom/gpi.c
@@ -476,12 +476,6 @@ struct gpi_dev {
struct gpii *gpiis;
};

-struct reg_info {
- char *name;
- u32 offset;
- u32 val;
-};
-
struct gchan {
struct virt_dma_chan vc;
u32 chid;
--
2.45.1

2024-05-20 16:19:29

by Frank Li

Subject: Re: [PATCH v3] dmaengine: qcom: gpi: remove unused struct 'reg_info'

On Sat, May 18, 2024 at 12:40:24AM +0100, [email protected] wrote:
> From: "Dr. David Alan Gilbert" <[email protected]>
>
> 'reg_info' was never used since it's initial
> commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver")
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
> Reviewed-by: Bryan O'Donoghue <[email protected]>

Reviewed-by: Frank Li <[email protected]>

> ---
> drivers/dma/qcom/gpi.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index 1c93864e0e4d..639ab304db9b 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
> @@ -476,12 +476,6 @@ struct gpi_dev {
> struct gpii *gpiis;
> };
>
> -struct reg_info {
> - char *name;
> - u32 offset;
> - u32 val;
> -};
> -
> struct gchan {
> struct virt_dma_chan vc;
> u32 chid;
> --
> 2.45.1
>

2024-06-11 18:32:17

by Vinod Koul

Subject: Re: [PATCH v3] dmaengine: qcom: gpi: remove unused struct 'reg_info'

On Sat, 18 May 2024 00:40:24 +0100, [email protected] wrote:
> 'reg_info' was never used since it's initial
> commit 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver")
> Remove it.
>
>

Applied, thanks!

[1/1] dmaengine: qcom: gpi: remove unused struct 'reg_info'
commit: 7dcf9e82e0a05cf7b7abccd0ce1b4ca598d70f08

Best regards,
--
Vinod Koul <[email protected]>